Repository navigation
fix(app-space): connect fork/join bar to the backbone stem (#2896 follow-up) - #2901
Merged
Merged
Conversation
…low-up) PR #2899 aligned the fork drops/ups to each lane's bubble center, but left the horizontal bar starting at lane-0's bubble (~61px) while the vertical stem sits at the backbone bubble center (1.175rem ≈ 51px) — a ~10px horizontal jog where the stem meets the bar (visible at the top of the fork in the CAP track). Measured on the live DEV page (event 10000015, CAP track): stem left 50.8, bar left 60.8 → 10px gap. Setting the bar's left to 1.175rem (the stem x) closes it: re-measured gap_stem_to_bar = 0. Verified against the real rendered DOM, not a static repro. Same change applied to the join-connector bar for tracks that have a downstream join.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR #2899 aligned the fork drops/ups to each lane's bubble center, but left the horizontal bar starting at lane-0's bubble while the vertical stem sits at the backbone bubble center — a ~10px horizontal jog where the stem meets the bar (the top of the fork in the CAP track, the connector the user flagged).
Measured, not guessed
On the live DEV page (event
10000015, CAP track — the two-Branch fork):left: 1.175rem)Drops vs lane bubbles were already ≤1px (that part of #2899 was correct). Verified against the real rendered DOM via Playwright, then screenshotted — the stem and bar now connect cleanly.
Change
Set both the
fork-connector__barandjoin-connector__barleftto1.175rem(the stem/down-stem x) instead oflaneBubbleLeft(0), so the bar reaches the backbone stem.right(last lane's drop) unchanged.Scope
CSS-positioning only in
AppSpace.vue; class names/structure unchanged, soAppSpace.segments.test.tsexistence assertions still pass. TargetDEV.