Repository navigation
feat(#2864): honor temporarily-unavailable path items in App Space - #2882
Merged
Merged
Conversation
The per-path-item temporarily-unavailable flag (admin-toggled, already honored on the mission page) was dropped by the App Space data path, so a disabled item still rendered as an active, clickable kiosk card. - path-item-task-resolver: shapeItem/buildPathItems now carry temporarilyUnavailable + unavailableReason on direct items (group-expanded children stamped false, matching the mission page). - app-space-gating: isTutorialOpenable returns false for unavailable items — the single chokepoint that both blocks the click and strips .clickable. - AppSpace.vue: 'Temporarily Unavailable' badge + reason, greyed/delinked card. Tests: buildPathItems passthrough, gating block, and a mounted-component test proving badge render + no window.open on click.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #2864's path-item "temporarily unavailable" flag is honored by the admin form, GraphQL,
loadMissionContext, and the mission page — but the App Space kiosk (/app-space/?eventId=...) has its own data path (getAppSpaceProgress→buildPathItems/shapeItem→AppSpace.vue) that was never wired. Reported live on DEV: the Joule Studio (BDC) item was set to disabled but stayed active/clickable on the app-space card.This is the whole purpose of the feature — quick-disable a broken/maintenance item from the live kiosk.
Fix
srv/lib/path-item-task-resolver.js—shapeItem/buildPathItemscarrytemporarilyUnavailable+unavailableReasonon direct items. Group-expanded children are stampedfalse(not inherited), matching the mission page (packages/content/catalog-data.js).hugo-apps/src/app-space/app-space-gating.ts—isTutorialOpenablereturnsfalsefor unavailable items. Single chokepoint: blocks the click handler AND strips theclickableclass.hugo-apps/src/app-space/AppSpace.vue— "Temporarily Unavailable" badge + reason, greyed + delinked card.Tests
test/unit/app-space-unavailable.test.js—buildPathItemsflag passthrough (direct carries, available defaults false, group child = false).test/unit/app-space-unavailable-gating.test.js— gating blocks opening, overrides the App Space completion time window #2866 redo exception.hugo-apps/src/app-space/__tests__/AppSpace.unavailable.test.ts— mounted component: badge + reason render, item greyed, title not clickable, nowindow.openon click.All 48 app-space suite tests pass; island bundle builds clean; vue-tsc clean.
Verification
Pending DEV deploy + live check on
eventId=10000015(Joule Studio BDC).