Conversation
…clean up call sites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new Quick Share feature for sending files and text to a paired Mac, and streamlines the manual disconnect logic throughout the app. It also improves the user experience and clarity around storage permissions and file access. The most important changes are summarized below.
Quick Share Feature:
QuickShareSendActivityfor handling Android share intents (SENDandSEND_MULTIPLE) and sending files or text to the paired Mac. This includes UI feedback and file caching logic. (app/src/main/java/com/sameerasw/airsync/presentation/ui/activities/QuickShareSendActivity.kt)QuickShareSendActivityand the supportingOutboundQuickShareServicein the manifest, with updated intent filters to support all file types and multiple files. (app/src/main/AndroidManifest.xml)Manual Disconnect Logic:
WebSocketUtil.disconnect(context, manual = true)and removed unnecessary calls tosetUserManuallyDisconnected, ensuring consistent manual disconnect handling from UI, BLE, and shortcuts. [1] [2] [3] [4] [5] [6] [7]Permissions and UI Improvements:
PermissionDialog.kt,PermissionsScreen.kt) [1] [2]These changes add a seamless way to share content from Android to Mac, unify disconnect logic for reliability, and improve clarity around permissions for end users.