fix: resolve six scaffold gaps from 1.29.0 audit (spec 017)#78
Merged
Conversation
- FR-1: separate angularCli version field and cap typescript on Angular peer range (<6.0) - FR-2: gate PrimeNG assets via --app-* token aliasing in styles.scss; flat styles[] from generator - FR-3: add ProjectConfig.database field, decouple JPA/postgres/flyway from --no-flyway - FR-4: --no-auth and --yes flags; auto-skip prompts when stdin is not a TTY - FR-5: ng test target with @angular/build:karma builder and one minimal sample spec - FR-6: emit frontend/proxy.conf.json mapping /api/** to backend port when both layers are scaffolded Audit items #9 (default JSON logs), #10 (default correlation-ID plumbing) and #12 (Spring Security marker dep) were rejected as speculative abstractions per constitution rule #6 and are listed Out of scope in the spec. Spec: specs/017-scaffold-gaps-fix/ Verification: 539 tests pass, 0 lint, 0 typecheck errors. E2E smokes: default scaffold, --ui none, --database none, non-TTY pipe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProjectConfig.databasefield, newResolvedVersions.angularClifield, new--no-auth/--yesCLI flags, non-TTY auto-skip, Angularng testworks out of the box, cross-layerproxy.conf.jsonwhen both layers are scaffolded.Spec: specs/017-scaffold-gaps-fix
Fixes
versions.ts: separate@angular/clifetch + typescript cap (<6.0 for Angular).package.json.hbsusesversions.angularCli.styles[]; components use--app-*aliased to--p-*only when PrimeNG. Zero--p-*references whenui=none.database: 'postgres' | 'none'onProjectConfig. Gates JPA + postgres driver + flyway. Forces flyway off whendatabase=none.--no-auth,-y/--yesdeclared onnewandadd. Non-TTY stdin auto-skips prompts and uses defaults.angular.jsonships atesttarget (@angular/build:karma),tsconfig.spec.json, and a minimalAppComponentJasmine spec. Karma+Jasmine devDeps hard-pinned (rule #6).frontend/proxy.conf.jsonand patchesserve.options.proxyConfigwhenbackendTypeis set. Port map: spring-boot=8080, fastapi=8000, nestjs=3000, nextjs=3000, laravel=8000.Test plan
npm run typecheckexits 0npm run lintexits 0 (0 issues found)npm test— 539 tests / 50 files all passingforgekit new demo --spring-boot --angular --yesproduces afrontend/package.jsonwith@angular/cli ^21.2.8(≠@angular/core ^21.2.10) andtypescript ~5.9.0(capped);proxy.conf.jsonpoints atlocalhost:8080forgekit add angular --ui noneproduces zero PrimeNG packages andangular.json styles = ["src/styles.scss"]forgekit add spring-boot --database noneproduces apom.xmlwith zero matches ofdata-jpa,postgresql, orflyway-coreyes | forgekit ... --yes) completes without ExitPromptError