refactor(claude-code): remove duplicated settings table, translate hookify rules to EN, delete dead pre-bash hook#76
Merged
Conversation
…lete dead pre-bash hook - CLAUDE.md.hbs: removed the `## Claude Settings` table — it duplicated settings.json (SSOT violation, Constitution Principle 3). - Hookify: all rules translated from French to English for consistency. - warn-todo-fixme + warn-console-log → `enabled: false` by default (opt-in via settings.local.json; too noisy as defaults). - Deleted `hooks/pre-bash.sh.hbs` + removed PreToolUse wiring from settings.json.hbs. The only rule was "block npm install outside frontend/", which was low value; hookify block-* rules already cover bash safety. Empty hook violated Principle 6 (no speculative abstractions). - Tests: 4 preset tests now assert settings.json values directly (SSOT) instead of CLAUDE.md table rows; hook tests updated for session-start only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
## Claude Settingstable — it duplicatedsettings.json, violating Constitution Principle 3 (ProjectConfig = single source of truth).settings.jsonis now the only place wheregit.strategy+speckit.*live.warn-todo-fixmeandwarn-console-lognow ship withenabled: false. Too noisy as defaults; opt-in viasettings.local.json.hooks/pre-bash.sh.hbs+ removedPreToolUsewiring fromsettings.json.hbs. Its only rule was "blocknpm installoutsidefrontend/", which was low-value duplication of what the hookifyblock-*rules already cover. With the rule gone, the hook was a no-op — deleted per Principle 6 (no speculative abstractions).Bash(npm install)+Bash(npm run)as duplicated inpermissions.allow— that was wrong. Without a wildcard,Bash(npm run)does not covernpm install. No permission changes.Test plan
npm test→ 423/423 pass (4 preset tests refactored to assertsettings.jsondirectly; hook tests updated forsession-start.shonly)npm run typechecknpm run lint