Skip to content

feat: add git strategy prompt for Vibe workflow mode - #70

Closed
salimomrani wants to merge 1 commit into
masterfrom
001-vibe-git-strategy-clean
Closed

feat: add git strategy prompt for Vibe workflow mode#70
salimomrani wants to merge 1 commit into
masterfrom
001-vibe-git-strategy-clean

Conversation

@salimomrani

Copy link
Copy Markdown
Owner

Summary

Adds a git strategy configuration prompt for Vibe workflow mode, allowing users to choose between PR-required and direct-push strategies. The choice is written to settings.json and guides Claude Code's behavior.

Changes

  • Add GitStrategy type to ProjectConfig (values: "pr-required" | "no-pr")
  • Add conditional prompt in Vibe workflow setup asking for git strategy
  • Update claude-code generator to use configured strategy
  • Update test fixtures and detection logic to include gitStrategy field
  • Generate spec, plan, tasks.md for feature tracking

Test plan

  • TypeScript compilation passes
  • claude-code tests pass
  • Prompt appears only when Vibe workflow selected
  • Both strategy options work correctly
  • Default to "pr-required" (safe default)
  • settings.json contains correct git.strategy value

Code Review

✅ All feedback from code review incorporated
✅ No type errors, clean compilation
✅ Proper conditional logic for Vibe-only prompt
✅ Backward compatible (defaults to "pr-required")
✅ Follows project constitution principles

- Add GitStrategy type ('pr-required' | 'no-pr') to ProjectConfig
- Add conditional git strategy prompt in project wizard (only for Vibe mode)
- Update claude-code generator to use gitStrategy from ProjectConfig
- Update test fixtures and configs to include gitStrategy field
- Default gitStrategy to 'pr-required' for safety

When users select Vibe workflow during setup, they're now asked to choose
between PR-required (safer) or direct-push (faster) strategies. The choice
is saved to settings.json and guides Claude Code's git behavior.

Spec, plan, and tasks documentation added to .specify/specs/001-vibe-git-strategy/.
@salimomrani

Copy link
Copy Markdown
Owner Author

Closing in favor of #72 - clean git strategy implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant