Ensure graph benchmark exits after reporting#2137
Closed
SNComrade wants to merge 1 commit into
Closed
Conversation
1f53c68 to
542dc0d
Compare
Author
|
Local verification while upstream fork Actions are waiting on approval:
Benchmark output reached |
Owner
|
Reviewing; will return after PR #2139 merges. The graph benchmark exit fix is targeted and looks like a real bug — ensuring the benchmark process exits cleanly after reporting. Will fast-track review once the quality sweep baseline is established. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Context
Recent upstream main V3 CI runs reached the ADR-130 benchmark summary, then the graph benchmark job stayed alive until GitHub canceled the workflow around the 40 minute timeout. This keeps the benchmark's existing report behavior and makes the process termination explicit after output is emitted.