fix(agentic-jujutsu): add macOS arm64 optional dependency#160
Open
LaloLalo1999 wants to merge 1 commit into
Open
fix(agentic-jujutsu): add macOS arm64 optional dependency#160LaloLalo1999 wants to merge 1 commit into
LaloLalo1999 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates platform-specific optional dependency artifacts for agentic-jujutsu to a new release and adds support for Apple Silicon on macOS.
Changes:
- Bump all existing
agentic-jujutsu-*optionalDependencies from2.3.5to2.3.6 - Add new optionalDependency for
agentic-jujutsu-darwin-arm64at2.3.6
Files not reviewed (1)
- packages/agentic-jujutsu/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
agentic-jujutsupackage metadata so Apple Silicon installs can resolve the generated N-API native package.Context
On macOS arm64,
jj-agentcurrently fails after a global install because the generated loader attempts to requireagentic-jujutsu-darwin-arm64, but the main package metadata does not list that platform package as an optional dependency. This was reproduced withagentic-jujutsu@2.3.6on Node v24.15.0 / macOS arm64.Related issue: #159
Changes
agentic-jujutsu-darwin-arm64topackages/agentic-jujutsu/package.jsonoptional dependencies.2.3.6.packages/agentic-jujutsu/package-lock.jsonto match package metadata.Key Implementation Details
The existing N-API loader already contains the correct macOS arm64 resolution path:
This PR makes the package metadata consistent with that loader path so npm can install the platform package once it is published as part of the release process.
Testing
Verified locally on macOS arm64:
Also passed repository pre-push checks when pushing the branch:
npm test tsc --noEmit --project ./agentic-flow/config/tsconfig.jsonNotes
The npm registry still needs a published
agentic-jujutsu-darwin-arm64@2.3.6artifact for the existing released version to install cleanly on Apple Silicon.