Open
Conversation
madsmtm
added
enhancement
madsmtm
commented
Jan 31, 2026
Comment on lines
+301
to
+317
| // Block until back buffer is no longer being used by the compositor. | ||
| // | ||
| // TODO: Allow configuring this: https://github.com/rust-windowing/softbuffer/issues/29 | ||
| // TODO: Is this actually the check we want to do? It seems like the compositor doesn't | ||
| // properly set the usage state when the application loses focus, even if you continue | ||
| // rendering there? | ||
| // | ||
| // Should we instead set up a `CVDisplayLink`, and only allow using the back buffer once a | ||
| // certain number of frames have passed since it was presented? Would be better though not | ||
| // perfect, `CVDisplayLink` isn't guaranteed to actually match the display's refresh rate: | ||
| // https://developer.apple.com/library/archive/documentation/GraphicsImaging/Conceptual/CoreVideo/CVProg_Concepts/CVProg_Concepts.html#//apple_ref/doc/uid/TP40001536-CH202-DontLinkElementID_2 | ||
| // | ||
| // Another option would be to keep a boundless queue as described in: | ||
| // https://github.com/commercial-emacs/commercial-emacs/blob/68f5a28a316ea0c553d4274ce86e95fc4a5a701a/src/nsterm.m#L10552-L10571 | ||
| while self.back.surface.is_in_use() { | ||
| std::thread::yield_now(); | ||
| } |
Member
Author
There was a problem hiding this comment.
The way we wait for the compositor to stop using the buffer(s) here is kinda bad, but that can be resolved later, and shouldn't be a problem for applications that either:
- Only re-render when something changes.
- Do proper frame-pacing (Winit doesn't yet provide that though).
Member
There was a problem hiding this comment.
When I run the animation example, it seems to sometimes work, but sometimes get stuck in this loop after the three buffers have been allocated.
madsmtm
force-pushed
the
madsmtm/iosurface
branch
from
e02da58 to
f1882c5
Compare
This was referenced Jan 31, 2026
madsmtm
force-pushed
the
madsmtm/iosurface
branch
from
f1882c5 to
31f0a29
Compare
Write directly into a shared memory buffer that can be shared directly with the compositor and avoids copying bytes when presenting (QuartzCore was copying stuff before). This also implements double and triple buffering of the surface, to avoid creating a bunch of unnecessary buffers. The compositor seems to sometimes work on two buffers at the same time? A bit unsure why. The way we wait for the compositor to stop using the buffer(s) is kinda bad, but that can be resolved later, and shouldn't be a problem for applications that do proper frame-pacing (which Winit doesn't yet provide though).
madsmtm
force-pushed
the
madsmtm/iosurface
branch
from
31f0a29 to
45b790a
Compare
ids1024
reviewed
Feb 2, 2026
Member
|
Hm. When I try this on an M1 Mac Mini running Tahoe 26.2, I'm not seeing it work correctly. Examples create windows with white contents, except it becomes partly visible if I drag another window over it. But that doesn't show up in a screenshot, which just shows the window white. |
Member
Author
|
It requires #321 (the alpha mode is diff --git a/src/pixel.rs b/src/pixel.rs
index bcc223d..eb08f30 100644
--- a/src/pixel.rs
+++ b/src/pixel.rs
@@ -101,7 +101,7 @@ impl Pixel {
/// ```
pub const fn new_rgb(r: u8, g: u8, b: u8) -> Self {
// FIXME(madsmtm): Change alpha to `0xff` once we support transparency.
- Self { r, g, b, a: 0x00 }
+ Self { r, g, b, a: 0xff }
}
/// Create a new pixel from a blue, a green and a red component. |
Member
Member
Author
|
Idk., I just preferred to wait for #321 (and I won't merge this one before that) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
Buffer<'_>be backed by a shared memory buffer that can be shared directly with the compositor. This makes the CoreGraphics backend zero-copy (QuartzCore was copying from theCGImageProviderinternally before when committing the transaction).This also implements triple buffering of the surface, to avoid creating a bunch of unnecessary buffers. The compositor seems to want to work on two buffers at the same time? A bit unsure why, but I know that we do get tearing if we try to touch things while it's working on it.
Fixes #83.
This requires #321, because
IOSurfacedoes not support RGBX (so the alpha channel must be opaque to render correctly).Tested on:
Replaces #95 and #96.