-
Notifications
You must be signed in to change notification settings - Fork 69
Disable the KMS/DRM backend by default #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
0841c1a to
7296b09
Compare
Not sure what the best tool is currently for measuring this, but |
|
I guess the reason why I wanted to do this was also motivated by #323, because I felt that DRM being a tier 3 platform somewhat warranted that the user more explicitly opted in to it. |
|
On the other hand, if winit still has no kms/drm backend, there's probably not much benefit to having this enabled by default, even if there isn't much harm either. The backend will only be used by projects that explicitly use it, in which case they can enable the feature. |
|
Yeah, that was my reasoning too. |
|
Maybe part of my problem is that I don't understand when you'd ever want to use this backend? Can you even use it if the desktop has Wayland or X11 installed and running? Isn't DRM/KMS more like the implementation detail of a Wayland compositor, not something you can actually use in e.g. a Bevy game? |
|
You'd use the DRM/KMS backend if you're running an application on a tty without Wayland or X11. I think it's relatively common to use Qt like this in embedded contexts: https://doc.qt.io/qt-6/embedded-linux.html. Though presumably most uses of softbuffer would want a winit backend as well. And in the mean time, a Wayland compositor like |
notgull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with this. Given the lack of bug reports I am sure that 0 people are using the KMS backend.
7296b09 to
b609adf
Compare
The backend was introduced in #135 to fix #42, but I feel like it's somewhat too niche for us to support as a "primary" platform.
In a sense, this is in preparation for some day dropping X11 as a default platform too (though that's years in the future, and should be coordinated with Winit).
Then again, maybe the cost of the extra
drm-*dependencies isn't large enough that it really matters?WDYT?