Fix all clippy warnings and run CI for all workspace packages#242
Open
00xc wants to merge 4 commits intorust-osdev:mainfrom
Open
Fix all clippy warnings and run CI for all workspace packages#24200xc wants to merge 4 commits intorust-osdev:mainfrom
00xc wants to merge 4 commits intorust-osdev:mainfrom
Conversation
Now that all clippy warnings have been fixed, simply run clippy for all packages in the workspace. While we are at it, emit an error on clippy warnings, which were previously being allowed.
Contributor
Author
|
@IsaacWoods could you review this? It extends clippy to all packages in the repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix remaining clippy warnigns and run CI for all workspace packages.
While we are at it, deny clippy warnings, which were previously slipping through.