feat: support changing the isolation level

[Bishops-exe]

No description provided.

[Bishops-exe]

not really trsted because tests are broken on windows

[syphar]

please add some tests where we can see if the different isolation levels work on windows.

How sure are we about compatibility? I wonder if we should run the whole windows testsuite for this (similar to what we do for gvisor), or if specific small tests are good enough.

[Bishops-exe]

please add some tests where we can see if the different isolation levels work on windows.

how should i detect that? should i just test if docker returns 0?

[syphar]

please add some tests where we can see if the different isolation levels work on windows.

how should i detect that? should i just test if docker returns 0?

I think it's good enough to run a command with the isolation level is set. If the CLI accepts it, we can assume it's ok.

In tests::buildtests you have some build-tests

[Bishops-exe]

now it should be good to go

[Bishops-exe]

why are buildtests skipped in ci? isnt that a bit counterintuitive

[Bishops-exe]

should i implement FromStr for Isolation struct?

[Bishops-exe]

@syphar

[syphar]

why are buildtests skipped in ci? isnt that a bit counterintuitive

Which are? some tests don't work on windows I think, from before I joined the project. I never had a windows system (and the time) to really try and see why.

Feel free to reactivate some and see where we land.

In any case, a test to see if the parameter works would be good.

[syphar]

should i implement FromStr for Isolation struct?

Im fine with or without. I added it for the new DockerRuntime because I want to load the option from environment variables when I'm using it in docs.rs.

[syphar]

why are buildtests skipped in ci? isnt that a bit counterintuitive

Which are? some tests don't work on windows I think, from before I joined the project. I never had a windows system (and the time) to really try and see why.

Feel free to reactivate some and see where we land.

In any case, a test to see if the parameter works would be good.

Just seeing the comment:

Integration tests are disabled on Windows as they take way too long to pull the Docker image

perhaps we can try reactivating this? Could be a separate PR.

Since you seem to start using rustwide on a windows host, I would feel more comfortable with better test coverage

[Bishops-exe]

ok, but we can merge this pr for now?

[syphar]

ok, but we can merge this pr for now?

Is there a way to just test if the arg works somehow? Not sure if the image-loading is faster now? or if we can use some smaller image?

If too slow you could confirm that this is manually tested and we can proceed?