Spawn a task for github webhooks to get around timeout - #2562
Merged
Conversation
JonathanBrouwer
commented
Sep 1, 2026
| let authorized_users = match get_authorized_users().await { | ||
| Ok(authorized_users) => authorized_users, | ||
| Err(err) => { | ||
| main_client.post_comment(issue.number, err).await; |
Member
Author
There was a problem hiding this comment.
I decided to post this as a comment, but maybe just log::error! is better?
Member
There was a problem hiding this comment.
It's good if we respond with something to the command, so this seems fine.
Kobzol
approved these changes
Sep 1, 2026
Kobzol
left a comment
Kobzol
left a comment
Member
There was a problem hiding this comment.
Thanks. I'll take a look at making the handler a bit faster.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the problem that happened here: rust-lang/rust#162117 (comment)