Make comment of triage build link back to the triage invocation - #2543
Merged
JonathanBrouwer merged 3 commits intoAug 22, 2026
Conversation
JonathanBrouwer
commented
Aug 21, 2026
JonathanBrouwer
commented
Aug 21, 2026
Kobzol
reviewed
Aug 21, 2026
Kobzol
left a comment
Kobzol
left a comment
Member
There was a problem hiding this comment.
Looks reasonable. There's not really an easy way to test this outside of production.
JonathanBrouwer
force-pushed
the
triage-run-detection
branch
from
August 21, 2026 22:00
725eddd to
5b29b42
Compare
Kobzol
approved these changes
Aug 22, 2026
Kobzol
left a comment
Kobzol
left a comment
Member
There was a problem hiding this comment.
Please get rid of the merge commit. Also suggested a rewording. Otherwise LGTM.
I use this to create a `GraphQLClient` locally to test against Github's api
JonathanBrouwer
force-pushed
the
triage-run-detection
branch
from
August 22, 2026 11:47
b99d6d7 to
8bf3d42
Compare
Member
Author
|
Oops sorry for that merge commit 💀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @Kobzol
Recommend reviewing commit by commit.
Again the "did not test this" disclaimer other than what I mentioned in the self-review