Skip to content

Uplift rustfmt macro formatting fix - #161370

Open
Manishearth wants to merge 1 commit into
rust-lang:mainfrom
Manishearth:rustfmt-macro-fix
Open

Uplift rustfmt macro formatting fix#161370
Manishearth wants to merge 1 commit into
rust-lang:mainfrom
Manishearth:rustfmt-macro-fix

Conversation

@Manishearth

Copy link
Copy Markdown
Member

This uplifts the fix for rust-lang/rustfmt#6985 (rust-lang/rustfmt#6990), which is a rustfmt ICE breaking multiple crates.

This should be backported to beta.

@Manishearth
Manishearth requested a review from fee1-dead August 19, 2026 18:33
@Manishearth Manishearth added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 19, 2026
@rustbot

rustbot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

rustfmt is developed in its own repository. If possible, consider making this change to rust-lang/rustfmt instead.

cc @rust-lang/rustfmt

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. labels Aug 19, 2026
@rustbot

rustbot commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: rustfmt, rustfmt-contributors
  • rustfmt, rustfmt-contributors expanded to 6 candidates
  • Random selection from fee1-dead, jieyouxu, ytmimi

@ytmimi

ytmimi commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@Manishearth you can r=me once CI is green

@Manishearth

Copy link
Copy Markdown
Member Author

@bors r=ytmimi

@rust-bors

rust-bors Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

📌 Commit d827d44 has been approved by ytmimi

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: To keep an eye on

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2026
@jieyouxu jieyouxu assigned ytmimi and unassigned jieyouxu Aug 20, 2026
@jieyouxu jieyouxu added beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Aug 20, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 20, 2026
…tmimi

Uplift rustfmt macro formatting fix

This uplifts the fix for rust-lang/rustfmt#6985 (rust-lang/rustfmt#6990), which is a rustfmt ICE breaking multiple crates.

This should be backported to beta.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 20, 2026
…tmimi

Uplift rustfmt macro formatting fix

This uplifts the fix for rust-lang/rustfmt#6985 (rust-lang/rustfmt#6990), which is a rustfmt ICE breaking multiple crates.

This should be backported to beta.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 20, 2026
…tmimi

Uplift rustfmt macro formatting fix

This uplifts the fix for rust-lang/rustfmt#6985 (rust-lang/rustfmt#6990), which is a rustfmt ICE breaking multiple crates.

This should be backported to beta.
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 20, 2026
…tmimi

Uplift rustfmt macro formatting fix

This uplifts the fix for rust-lang/rustfmt#6985 (rust-lang/rustfmt#6990), which is a rustfmt ICE breaking multiple crates.

This should be backported to beta.
rust-bors Bot pushed a commit that referenced this pull request Aug 20, 2026
…uwer

Rollup of 20 pull requests

Successful merges:

 - #152617 (std: implement `sleep_until` for Fuchsia)
 - #158934 (diagnostics: fix `let x: vec![]` suggestion pointing into stdlib)
 - #161277 (bootstrap: Move all non-module items out of the crate root)
 - #161295 (std: don't panic on long-elapsed deadlines for `sleep_until`)
 - #161368 (Double-word align `_Unwind_Exception`)
 - #161370 (Uplift rustfmt macro formatting fix)
 - #161378 (`FlowSensitiveAnalysis` cleanups)
 - #158032 (Offload expose device selection)
 - #158855 (Add `desktop` method to `CommandExt`)
 - #161199 (Add regression test for non lifetime binders)
 - #161302 (Add regression test for inconsistent import resolution from issue 147208)
 - #161329 (Add regression tests for a few fixed issues with E-needs-test)
 - #161330 (Add regression test for nested RPIT not an iterator ICE)
 - #161351 (Cleanup: Move impl of `#[rustc_dump_object_lifetime_defaults]`)
 - #161355 (Add file path to some archive build errors)
 - #161373 (Allow running EC2 jobs locally)
 - #161393 (Configure LLM policy URL for triagebot)
 - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test)
 - #161410 (Fix rustdoc remapping `documentation` scope documentation)
 - #161415 (Update expect messages in path docs to better follow guidelines)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants