resolving cyclic glob vis-max - #161024
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Contributor
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 18, 2026
…uwer Rollup of 11 pull requests Successful merges: - #161024 (resolving cyclic glob vis-max) - #161231 (passes: `rustc_scalable_vector` fields are not dead) - #161238 (remove scalar size mismatch interpreter error, make it an ICE instead) - #160345 (Resolver: add `checked` methods for `Cm(Ref)Cell`) - #161129 (Avoid ICE when recovering parenthesized type parameters) - #161235 (Compute job time in post-merge-report from the actual GitHub duration) - #161239 (Fix `#[repr(transparent)]` wrapper types not working with `Complex<T>`) - #161244 (Add regression test for indexing an unsized static without a body) - #161257 (Ignore target feature test when LLVM fails to compile minicore) - #161258 (perf: return early from in_external_macro for root contexts) - #161278 (Add regression test for normalization failure on erased closure in async block)
rust-bors Bot
pushed a commit
that referenced
this pull request
Aug 18, 2026
Rollup merge of #161024 - calvinrp:fix/pub-visibility, r=petrochenkov resolving cyclic glob vis-max Fixes #160685 #159039 follows `ambiguity_vis_max`. Mutual globs can cycle that and overflow the stack. Visit each most-visible glob once, and still walk `source_decl` so it stays public. Also shortened the #159038 regression-test headers. r? petrochenkov @rustbot label +A-resolve +A-visibility +T-compiler +beta-nominated
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
Aug 19, 2026
…uwer Rollup of 11 pull requests Successful merges: - rust-lang/rust#161024 (resolving cyclic glob vis-max) - rust-lang/rust#161231 (passes: `rustc_scalable_vector` fields are not dead) - rust-lang/rust#161238 (remove scalar size mismatch interpreter error, make it an ICE instead) - rust-lang/rust#160345 (Resolver: add `checked` methods for `Cm(Ref)Cell`) - rust-lang/rust#161129 (Avoid ICE when recovering parenthesized type parameters) - rust-lang/rust#161235 (Compute job time in post-merge-report from the actual GitHub duration) - rust-lang/rust#161239 (Fix `#[repr(transparent)]` wrapper types not working with `Complex<T>`) - rust-lang/rust#161244 (Add regression test for indexing an unsized static without a body) - rust-lang/rust#161257 (Ignore target feature test when LLVM fails to compile minicore) - rust-lang/rust#161258 (perf: return early from in_external_macro for root contexts) - rust-lang/rust#161278 (Add regression test for normalization failure on erased closure in async block)
Collaborator
|
beta backport approved as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels are handled by them. |
rustbot
added
the
beta-accepted
cuviper
removed
the
beta-nominated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #160685
#159039 follows
ambiguity_vis_max. Mutual globs can cycle that and overflow the stack. Visit each most-visible glob once, and still walksource_declso it stays public.Also shortened the #159038 regression-test headers.
r? petrochenkov
@rustbot label +A-resolve +A-visibility +T-compiler +beta-nominated
LLM helped investigate and simplify. I wrote the change and this text.