Staticlib rename internal symbols: add COFF support - #160679
Open
cezarbbb wants to merge 1 commit into
Open
Conversation
rustbot
added
A-run-make
cezarbbb
force-pushed
the
staticlib-rename-coff
branch
from
August 7, 2026 09:25
3a890b2 to
3d2cea7
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
bjorn3
reviewed
Aug 27, 2026
| strip_underscore: bool, | ||
| ) -> Option<Vec<u8>> { | ||
| // COFF has no visibility concept, so hide is a no-op. | ||
| let _ = (hide, exported); |
Member
There was a problem hiding this comment.
Maybe assert!(!hide)?
bjorn3
reviewed
Aug 27, 2026
| result[strtab_base..strtab_base + 4].copy_from_slice(&new_len.to_le_bytes()); | ||
| result.extend_from_slice(&new_strtab); | ||
|
|
||
| // Long names are stored as name[0] = 0 and name[4..8] = string table offset. |
Member
There was a problem hiding this comment.
What about name[1..4]? Is that ignored? Perhaps fill that with zeros too?
Edit: According to https://bitsavers.org/pdf/att/unix/System_V_386_Release_3.2/UNIX_System_V_386_Release_3.2_Programmers_Guide_Vol2_1989.pdf page 11-23, the four first bytes all need to be zero for a long symbol name.
bjorn3
added
S-waiting-on-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #156950.
-Zstaticlib-rename-internal-symbolsnow also works on COFF targets (Windows). Renaming only rewrites symbol names, so unlike hide it needs no visibility concept.COFF objects keep their string table at the end of the file, so renames append the new names there and patch the 4-byte length prefix plus each symbol's name offset in place. Both regular and bigobj objects are handled; on i686 a leading underscore is stripped when matching against the exported set. The archive format differs (GNU ar on windows-gnu, COFF on windows-msvc) but the members are always COFF objects, so the existing archive code is unchanged.
Supported on ELF, Apple, and COFF targets.
-Zstaticlib-hide-internal-symbolsremains ELF/Apple-only and still warns on Windows.A run-make test
staticlib-rename-internal-symbols-coffmirrors the existing ELF and Mach-O tests.r? @bjorn3