Skip to content

compiletest: forward disable-minification from bootstrap - #159887

Open
AayushMainali-Github wants to merge 1 commit into
rust-lang:mainfrom
AayushMainali-Github:fix-142737-forward-disable-minification
Open

compiletest: forward disable-minification from bootstrap#159887
AayushMainali-Github wants to merge 1 commit into
rust-lang:mainfrom
AayushMainali-Github:fix-142737-forward-disable-minification

Conversation

@AayushMainali-Github

@AayushMainali-Github AayushMainali-Github commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

build.docs-minification = false was already honored when building docs through bootstrap's doc steps, but compiletest-driven rustdoc suites always generated minified CSS/JS.

Bootstrap now forwards --disable-minification to compiletest when docs minification is disabled, and compiletest passes -Zunstable-options --disable-minification to rustdoc for HTML/JS/JSON/UI doc generation.

Fixes #142737.

@rustbot

rustbot commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/compiletest

cc @jieyouxu

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 25, 2026
@rustbot

rustbot commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue
Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @jieyouxu, @oli-obk, @wesleywiser, bootstrap
  • @jieyouxu, @oli-obk, @wesleywiser, bootstrap expanded to 8 candidates
  • Random selection from Mark-Simulacrum, clubby789, oli-obk, wesleywiser

@oli-obk

oli-obk commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

r? rustdoc

can individual tests override this flag? or... would they want to? is that useful?

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 28, 2026
@rustbot rustbot assigned lolbinarycat and unassigned oli-obk Jul 28, 2026
@AayushMainali-Github

AayushMainali-Github commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

No per-test override here. Tests can already add rustdoc flags via //@ doc-flags, but can't re-enable minification when bootstrap disables it. That seems fine for a global docs preference

@rust-bors

This comment has been minimized.

Sign in to view
@lolbinarycat

lolbinarycat commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Looks solid, just needs a trivial rebase and it should be good!

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2026
@rustbot

rustbot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@AayushMainali-Github
compiletest: forward disable-minification from bootstrap
bed62ed 
Honor build.docs-minification=false for rustdoc suites run via
compiletest by forwarding --disable-minification to rustdoc.
@AayushMainali-Github
AayushMainali-Github force-pushed the fix-142737-forward-disable-minification branch from dc8dc74 to bed62ed Compare August 21, 2026 20:14
@rustbot

rustbot commented Aug 21, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@AayushMainali-Github

AayushMainali-Github commented Aug 22, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2026
@lolbinarycat

lolbinarycat commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

@bors r+

@rust-bors

rust-bors Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

📌 Commit bed62ed has been approved by lolbinarycat

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#159887 - AayushMainali-Github:fix-142737-fo…
7e5a9e9 
…rward-disable-minification, r=lolbinarycat

compiletest: forward disable-minification from bootstrap

`build.docs-minification = false` was already honored when building docs through bootstrap's doc steps, but compiletest-driven rustdoc suites always generated minified CSS/JS.

Bootstrap now forwards `--disable-minification` to compiletest when docs minification is disabled, and compiletest passes `-Zunstable-options --disable-minification` to rustdoc for HTML/JS/JSON/UI doc generation.

Fixes rust-lang#142737.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 22, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#159887 - AayushMainali-Github:fix-142737-fo…
628b695 
…rward-disable-minification, r=lolbinarycat

compiletest: forward disable-minification from bootstrap

`build.docs-minification = false` was already honored when building docs through bootstrap's doc steps, but compiletest-driven rustdoc suites always generated minified CSS/JS.

Bootstrap now forwards `--disable-minification` to compiletest when docs minification is disabled, and compiletest passes `-Zunstable-options --disable-minification` to rustdoc for HTML/JS/JSON/UI doc generation.

Fixes rust-lang#142737.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 22, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#159887 - AayushMainali-Github:fix-142737-fo…
ead9310 
…rward-disable-minification, r=lolbinarycat

compiletest: forward disable-minification from bootstrap

`build.docs-minification = false` was already honored when building docs through bootstrap's doc steps, but compiletest-driven rustdoc suites always generated minified CSS/JS.

Bootstrap now forwards `--disable-minification` to compiletest when docs minification is disabled, and compiletest passes `-Zunstable-options --disable-minification` to rustdoc for HTML/JS/JSON/UI doc generation.

Fixes rust-lang#142737.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 22, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Aug 22, 2026
@JonathanBrouwer
Rollup merge of rust-lang#159887 - AayushMainali-Github:fix-142737-fo…
f1e9baa 
…rward-disable-minification, r=lolbinarycat

compiletest: forward disable-minification from bootstrap

`build.docs-minification = false` was already honored when building docs through bootstrap's doc steps, but compiletest-driven rustdoc suites always generated minified CSS/JS.

Bootstrap now forwards `--disable-minification` to compiletest when docs minification is disabled, and compiletest passes `-Zunstable-options --disable-minification` to rustdoc for HTML/JS/JSON/UI doc generation.

Fixes rust-lang#142737.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Aug 22, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Aug 22, 2026
@bors
Auto merge of #161559 - JonathanBrouwer:rollup-SYHwGWK, r=JonathanBro…
3cc27ca 
…uwer

Rollup of 7 pull requests

Successful merges:

 - #157513 (Reject non-constructor self types in const-arg tuple-call lowering)
 - #159887 (compiletest: forward disable-minification from bootstrap)
 - #160949 (Add floating point inline ASM support for SPARC)
 - #156160 (feat: add symmetric PartialEq impls for Vec, &[T], &mut [T] versus Cow<'_, [T]>)
 - #160302 (target_features: sse (or at least avx2) is incompatible with soft-float ABI)
 - #160914 (Derive `GenericTypeVisitable` for `RegionConstraint` _correctly_)
 - #161341 (be more permissive wrt overflow and and improve diagnostics)
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 22, 2026
@jhpratt
Rollup merge of rust-lang#159887 - AayushMainali-Github:fix-142737-fo…
a997973 
…rward-disable-minification, r=lolbinarycat

compiletest: forward disable-minification from bootstrap

`build.docs-minification = false` was already honored when building docs through bootstrap's doc steps, but compiletest-driven rustdoc suites always generated minified CSS/JS.

Bootstrap now forwards `--disable-minification` to compiletest when docs minification is disabled, and compiletest passes `-Zunstable-options --disable-minification` to rustdoc for HTML/JS/JSON/UI doc generation.

Fixes rust-lang#142737.
@jhpratt jhpratt mentioned this pull request Aug 22, 2026
Open
rust-bors Bot pushed a commit that referenced this pull request Aug 23, 2026
@bors
Auto merge of #161566 - jhpratt:rollup-PxRQM5u, r=jhpratt
3cc2003 
Rollup of 8 pull requests

Successful merges:

 - #161558 (stdarch subtree update)
 - #159887 (compiletest: forward disable-minification from bootstrap)
 - #160229 (Extend `dropping_{references,copy_types}` lints to `drop_in_place`)
 - #160949 (Add floating point inline ASM support for SPARC)
 - #156160 (feat: add symmetric PartialEq impls for Vec, &[T], &mut [T] versus Cow<'_, [T]>)
 - #160914 (Derive `GenericTypeVisitable` for `RegionConstraint` _correctly_)
 - #161341 (be more permissive wrt overflow and and improve diagnostics)
 - #161530 (Add regression test for gce dependency ICE in non-gce crate)
rust-bors Bot pushed a commit that referenced this pull request Aug 23, 2026
@bors
Auto merge of #161566 - jhpratt:rollup-PxRQM5u, r=jhpratt
b215b3c 
Rollup of 8 pull requests

Successful merges:

 - #161558 (stdarch subtree update)
 - #159887 (compiletest: forward disable-minification from bootstrap)
 - #160229 (Extend `dropping_{references,copy_types}` lints to `drop_in_place`)
 - #160949 (Add floating point inline ASM support for SPARC)
 - #156160 (feat: add symmetric PartialEq impls for Vec, &[T], &mut [T] versus Cow<'_, [T]>)
 - #160914 (Derive `GenericTypeVisitable` for `RegionConstraint` _correctly_)
 - #161341 (be more permissive wrt overflow and and improve diagnostics)
 - #161530 (Add regression test for gce dependency ICE in non-gce crate)
rust-bors Bot pushed a commit that referenced this pull request Aug 23, 2026
@bors
Auto merge of #161566 - jhpratt:rollup-PxRQM5u, r=jhpratt
baf1f7c 
Rollup of 8 pull requests

Successful merges:

 - #161558 (stdarch subtree update)
 - #159887 (compiletest: forward disable-minification from bootstrap)
 - #160229 (Extend `dropping_{references,copy_types}` lints to `drop_in_place`)
 - #160949 (Add floating point inline ASM support for SPARC)
 - #156160 (feat: add symmetric PartialEq impls for Vec, &[T], &mut [T] versus Cow<'_, [T]>)
 - #160914 (Derive `GenericTypeVisitable` for `RegionConstraint` _correctly_)
 - #161341 (be more permissive wrt overflow and and improve diagnostics)
 - #161530 (Add regression test for gce dependency ICE in non-gce crate)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lolbinarycat lolbinarycat

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

disable-minification is not forwarded to compiletest

4 participants

@AayushMainali-Github @rustbot @oli-obk @lolbinarycat