std: implement `sleep_until` for Fuchsia by joboet · Pull Request #152617 · rust-lang/rust

joboet · 2026-02-14T14:10:20Z

Tracking issue: #113752

Unfortunately Fuchsia's clock_nanosleep is only a stub. The kernel's zx_nanosleep syscall however does exactly what's needed.

I've done a few drive-by changes in the two outer commits, our uses of zx_time_t use the zx_instant_mono_t alias nowadays and the syscall table in the sleep_until documentation didn't mark the function names as code.

@rustbot ping fuchsia

rustbot · 2026-02-14T14:10:26Z

Hey friends of Fuchsia! This issue could use some guidance on how this should be
resolved/implemented on Fuchsia. Could one of you weigh in?

cc @erickt @Nashenas88

rustbot · 2026-02-14T14:10:27Z

r? @ibraheemdev

rustbot has assigned @ibraheemdev.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: @ChrisDenton, libs
@ChrisDenton, libs expanded to 8 candidates
Random selection from Mark-Simulacrum, ibraheemdev

Nashenas88 · 2026-03-11T20:43:21Z

Sorry for the delay here. I was on vacation, then out sick for a bit.

The implementation looks correct to me. Thank you for updating the zx_time_ts to zx_instant_mono_ts! I'll take this back to the team since I believe we should have updated the rust bindings when that change was made.

One nit on the commit comment: while most usages of zx_time_t are now zx_instant_mono_t, there are still usages where zx_time_t is valid and distinct from zx_instant_mono_t. I believe this is always the case where the exact timeline used (e.g. boot or monotonic) is configurable. For example, with zx_timer_set.

joboet · 2026-08-18T12:36:30Z

@rustbot reroll

nia-e · 2026-08-18T21:40:02Z

I don't suppose there's any fuschia runner to allow us to add a test? shame. the job for it seems to have been disabled for a while as well 🫠

i suppose it's at least worth a rebase and check build if you have a local fuchsia machine this can run on, since it is a tier 2 target

nia-e · 2026-08-19T04:50:34Z

dug into this a bit - seems like fuchsia ci is just ... a lost cause for now & google does their own internal testing if they care? either way, not something that should be libs' task to fix, and it seems like you did your due diligence here. ill wait for a rebase just in case and then r=me

erickt · 2026-08-19T16:32:15Z

Oh shucks I forgot we had the fuchsia ci turned off. I’ll try to get it back on. I’m the meantime I’ll run this code by our time folks to make sure this implementation is correct.

erickt · 2026-08-19T21:20:14Z

+/// | Hurd      | [`clock_nanosleep`] (Monotonic Clock)                                |
+/// | Vxworks   | [`clock_nanosleep`] (Monotonic Clock)                                |
 /// | Apple     | `mach_wait_until`                                                    |
+/// | Fuchsia   | [`zx_nanosleep`]                                                     |


zx_nanosleep is also using our monotonic clock, so this should be:

/// | Fuchsia | [`zx_nanosleep`] (Monotonic Clock)

View changes since the review

The "(Monotonic Clock)" comment is only relevant for clock_nanosleep since it can also be used with CLOCK_REALTIME. The situation on the Apple platforms – where there is no comment – is the same as on Fuchsia, the API only supports one clock.

erickt · 2026-08-19T21:20:43Z

This looks correct, other than the one comment. Thanks so much for implementing this for us!

rustbot · 2026-08-20T11:25:22Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

joboet · 2026-08-20T11:27:59Z

Thank you having a look @erickt 😊! And thanks, Nia, for picking this up.

Rebased and rechecked, it still works, so
@bors r=@nia-e

rust-bors · 2026-08-20T11:28:02Z

📌 Commit 1c0a0d9 has been approved by nia-e

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: Main branch is broken

@rustbot

std: implement `sleep_until` for Fuchsia Tracking issue: rust-lang#113752 Unfortunately Fuchsia's `clock_nanosleep` is [only a stub](https://cs.opensource.google/fuchsia/fuchsia/+/main:zircon/third_party/ulib/musl/src/time/clock_nanosleep.c;l=4;drc=26e68e7948a6cc4a1c4a0c8eb19b7e4a2dc27153). The kernel's `zx_nanosleep` syscall however does exactly what's needed. I've done a few drive-by changes in the two outer commits, our uses of `zx_time_t` use the `zx_instant_mono_t` alias nowadays and the syscall table in the `sleep_until` documentation didn't mark the function names as code. @rustbot ping fuchsia

@rustbot

std: implement `sleep_until` for Fuchsia Tracking issue: rust-lang#113752 Unfortunately Fuchsia's `clock_nanosleep` is [only a stub](https://cs.opensource.google/fuchsia/fuchsia/+/main:zircon/third_party/ulib/musl/src/time/clock_nanosleep.c;l=4;drc=26e68e7948a6cc4a1c4a0c8eb19b7e4a2dc27153). The kernel's `zx_nanosleep` syscall however does exactly what's needed. I've done a few drive-by changes in the two outer commits, our uses of `zx_time_t` use the `zx_instant_mono_t` alias nowadays and the syscall table in the `sleep_until` documentation didn't mark the function names as code. @rustbot ping fuchsia

@rustbot

std: implement `sleep_until` for Fuchsia Tracking issue: rust-lang#113752 Unfortunately Fuchsia's `clock_nanosleep` is [only a stub](https://cs.opensource.google/fuchsia/fuchsia/+/main:zircon/third_party/ulib/musl/src/time/clock_nanosleep.c;l=4;drc=26e68e7948a6cc4a1c4a0c8eb19b7e4a2dc27153). The kernel's `zx_nanosleep` syscall however does exactly what's needed. I've done a few drive-by changes in the two outer commits, our uses of `zx_time_t` use the `zx_instant_mono_t` alias nowadays and the syscall table in the `sleep_until` documentation didn't mark the function names as code. @rustbot ping fuchsia

@rustbot

std: implement `sleep_until` for Fuchsia Tracking issue: rust-lang#113752 Unfortunately Fuchsia's `clock_nanosleep` is [only a stub](https://cs.opensource.google/fuchsia/fuchsia/+/main:zircon/third_party/ulib/musl/src/time/clock_nanosleep.c;l=4;drc=26e68e7948a6cc4a1c4a0c8eb19b7e4a2dc27153). The kernel's `zx_nanosleep` syscall however does exactly what's needed. I've done a few drive-by changes in the two outer commits, our uses of `zx_time_t` use the `zx_instant_mono_t` alias nowadays and the syscall table in the `sleep_until` documentation didn't mark the function names as code. @rustbot ping fuchsia

…uwer Rollup of 20 pull requests Successful merges: - #152617 (std: implement `sleep_until` for Fuchsia) - #158934 (diagnostics: fix `let x: vec![]` suggestion pointing into stdlib) - #161277 (bootstrap: Move all non-module items out of the crate root) - #161295 (std: don't panic on long-elapsed deadlines for `sleep_until`) - #161368 (Double-word align `_Unwind_Exception`) - #161370 (Uplift rustfmt macro formatting fix) - #161378 (`FlowSensitiveAnalysis` cleanups) - #158032 (Offload expose device selection) - #158855 (Add `desktop` method to `CommandExt`) - #161199 (Add regression test for non lifetime binders) - #161302 (Add regression test for inconsistent import resolution from issue 147208) - #161329 (Add regression tests for a few fixed issues with E-needs-test) - #161330 (Add regression test for nested RPIT not an iterator ICE) - #161351 (Cleanup: Move impl of `#[rustc_dump_object_lifetime_defaults]`) - #161355 (Add file path to some archive build errors) - #161373 (Allow running EC2 jobs locally) - #161393 (Configure LLM policy URL for triagebot) - #161409 (Add back `tests/rustdoc-gui/notable-trait.goml` test) - #161410 (Fix rustdoc remapping `documentation` scope documentation) - #161415 (Update expect messages in path docs to better follow guidelines)

Rollup of 25 pull requests Successful merges: - #152617 (std: implement `sleep_until` for Fuchsia) - #158934 (diagnostics: fix `let x: vec![]` suggestion pointing into stdlib) - #160995 (Tiny readability cleanups for initialization dataflow analyses) - #161277 (bootstrap: Move all non-module items out of the crate root) - #161295 (std: don't panic on long-elapsed deadlines for `sleep_until`) - #161368 (Double-word align `_Unwind_Exception`) - #161370 (Uplift rustfmt macro formatting fix) - #161378 (`FlowSensitiveAnalysis` cleanups) - #161420 (Bump wasm-component-ld to 0.5.30) - #161429 (Tighten allocator `Send`/`Sync` requirements for `Arc` in preparation for refactor) - #158032 (Offload expose device selection) - #158855 (Add `desktop` method to `CommandExt`) - #160299 (Stabilize `bool::toggle`) - #160842 (Apply `&[T]` visualizer to `*const [T]`, `*mut [T]` and `Box<[T]>`) - #160981 (Partially support building and locating wasm proc-macros) - #161199 (Add regression test for non lifetime binders) - #161212 (rust-installer/install-template.sh: catch cp(1) error when installing…) - #161302 (Add regression test for inconsistent import resolution from issue 147208) - #161329 (Add regression tests for a few fixed issues with E-needs-test) - #161330 (Add regression test for nested RPIT not an iterator ICE) - #161331 (Bitset simplifications) - #161340 (rustdoc: enable scrolling only on table/code) - #161351 (Cleanup: Move impl of `#[rustc_dump_object_lifetime_defaults]`) - #161355 (Add file path to some archive build errors) - #161373 (Allow running EC2 jobs locally)

@rustbot

Rollup merge of #152617 - joboet:fuchsia_sleep_until, r=nia-e std: implement `sleep_until` for Fuchsia Tracking issue: #113752 Unfortunately Fuchsia's `clock_nanosleep` is [only a stub](https://cs.opensource.google/fuchsia/fuchsia/+/main:zircon/third_party/ulib/musl/src/time/clock_nanosleep.c;l=4;drc=26e68e7948a6cc4a1c4a0c8eb19b7e4a2dc27153). The kernel's `zx_nanosleep` syscall however does exactly what's needed. I've done a few drive-by changes in the two outer commits, our uses of `zx_time_t` use the `zx_instant_mono_t` alias nowadays and the syscall table in the `sleep_until` documentation didn't mark the function names as code. @rustbot ping fuchsia

joboet marked this pull request as ready for review February 14, 2026 14:10

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 14, 2026

rustbot assigned ibraheemdev Feb 14, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 14, 2026

joboet mentioned this pull request Feb 14, 2026

Tracking Issue for thread::sleep_until #113752

Open

10 tasks

This comment has been minimized.

Sign in to view

joboet force-pushed the fuchsia_sleep_until branch from 2e608fb to 8e4293c Compare May 21, 2026 13:46

This comment has been minimized.

Sign in to view

joboet force-pushed the fuchsia_sleep_until branch from 8e4293c to a31064a Compare May 21, 2026 13:48

rustbot assigned nia-e and unassigned ibraheemdev Aug 18, 2026

erickt reviewed Aug 19, 2026

View reviewed changes

joboet added 3 commits August 20, 2026 13:19

std: update definitions on Fuchsia

ed151ed

std: implement sleep_until for Fuchsia

95d6b37

std: update sleep_until syscall table

1c0a0d9

joboet force-pushed the fuchsia_sleep_until branch from a31064a to 1c0a0d9 Compare August 20, 2026 11:25

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2026

JonathanBrouwer mentioned this pull request Aug 20, 2026

Rollup of 16 pull requests #161399

Closed

JonathanBrouwer mentioned this pull request Aug 20, 2026

Rollup of 16 pull requests #161406

Closed

JonathanBrouwer mentioned this pull request Aug 20, 2026

Rollup of 21 pull requests #161417

Closed

JonathanBrouwer mentioned this pull request Aug 20, 2026

Rollup of 20 pull requests #161425

Closed

jhpratt mentioned this pull request Aug 21, 2026

Rollup of 25 pull requests #161434

Merged

rust-bors Bot merged commit 81d5d74 into rust-lang:main Aug 21, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Aug 21, 2026

Uh oh!

Uh oh!

Conversation

joboet commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 14, 2026

Uh oh!

rustbot commented Feb 14, 2026

Uh oh!

This comment has been minimized.

Nashenas88 commented Mar 11, 2026

Uh oh!

This comment has been minimized.

joboet commented Aug 18, 2026

Uh oh!

nia-e commented Aug 18, 2026

Uh oh!

nia-e commented Aug 19, 2026

Uh oh!

erickt commented Aug 19, 2026

Uh oh!

erickt Aug 19, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

joboet Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erickt commented Aug 19, 2026

Uh oh!

rustbot commented Aug 20, 2026

Uh oh!

joboet commented Aug 20, 2026

Uh oh!

rust-bors Bot commented Aug 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

joboet commented Feb 14, 2026 •

edited

Loading

erickt Aug 19, 2026 •

edited by rustbot

Loading

joboet Aug 20, 2026 •

edited

Loading