Build rustc and codegen backends with -Zembed-metadata=no - #151061
Conversation
This comment has been minimized.
This comment has been minimized.
Build rustc and codegen backends with -Zno-embed-metadata
|
And the baseline to compare the disk space against for try builds: @bors try |
Build rustc and codegen backends with -Zno-embed-metadata
This comment has been minimized.
This comment has been minimized.
|
r? @Kobzol |
6e25c8e to
b6605c3
Compare
|
For the try build it saves 2GB or 4% of the total space the build takes (46GB -> 44GB). Hoped it would be a bit more, but still not bad I think. And maybe it gives a higher relative saving when not collecting PGO profiles? @rustbot ready |
|
Let's do a full try build to see the codegen backend savings (we can compare them with the parent commit, should be enough), and also run perf., just in case. @bors try jobs=dist-x86_64-linux @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Build rustc and codegen backends with -Zno-embed-metadata try-job: dist-x86_64-linux
|
For cg_clif the |
This comment has been minimized.
This comment has been minimized.
|
Finished benchmarking commit (2cbe7f7): comparison URL. Overall result: no relevant changes - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (secondary -1.4%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 2.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 476.337s -> 475.884s (-0.10%) |
|
Before: After: And no other components seem to have changed their size. Yeah, pretty nice, a solid ~10%! |
|
Could you please rebase this onto #161102, and apply it to everything in |
5e75882 to
005f20e
Compare
This comment has been minimized.
This comment has been minimized.
|
You can r=me if CI passes. |
This comment has been minimized.
This comment has been minimized.
|
Hmm, there are some steps that run with in-tree Cargo even without |
|
@rustbot blocked |
This comment has been minimized.
This comment has been minimized.
While this won't change much for rustc and rustc-dev, it should make codegen backends a bit smaller by omitting their crate metadata. In addition it should reduce disk usage while compiling.
005f20e to
bbc9e66
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@rustbot ready |
|
@bors try jobs=x86_64-gnu,x86_64-msvc*,aarch64-apple* |
This comment has been minimized.
This comment has been minimized.
Build rustc and codegen backends with -Zembed-metadata=no try-job: x86_64-gnu try-job: x86_64-msvc* try-job: aarch64-apple*
|
Ok, looks good! Let's try. @bors r+ rollup=iffy |
…Kobzol Build rustc and codegen backends with -Zembed-metadata=no While this won't change much for rustc and rustc-dev, it should make codegen backends a bit smaller by omitting their crate metadata. In addition it should reduce disk usage while compiling. Follow up to rust-lang#145343
…Kobzol Build rustc and codegen backends with -Zembed-metadata=no While this won't change much for rustc and rustc-dev, it should make codegen backends a bit smaller by omitting their crate metadata. In addition it should reduce disk usage while compiling. Follow up to rust-lang#145343
…Kobzol Build rustc and codegen backends with -Zembed-metadata=no While this won't change much for rustc and rustc-dev, it should make codegen backends a bit smaller by omitting their crate metadata. In addition it should reduce disk usage while compiling. Follow up to rust-lang#145343
View all comments
While this won't change much for rustc and rustc-dev, it should make codegen backends a bit smaller by omitting their crate metadata. In addition it should reduce disk usage while compiling.
Follow up to #145343