constify (the unstable) str::as_str - #145930
Merged
Merged
Conversation
commented
Aug 27, 2025
|
r? @ibraheemdev rustbot has assigned @ibraheemdev. Use |
commented
Aug 27, 2025
|
Confused how this could have possibly passed CI without a |
commented
Aug 27, 2025
Author
|
I think they got reworked a few months ago to inherit stability and feature name from the non-const attributes. |
commented
Aug 27, 2025
|
Right! Sorry, I was forgetting that this method is still unstable. Carry on, then. |
commented
Aug 28, 2025
Member
|
@bors r+ rollup |
commented
Aug 28, 2025
ghost
deleted the
const_str_as_str
branch
August 28, 2025 17:32
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #130366
The method was not initially marked
constpresumably because it is only useful withDeref. But now that const traits seem to be a thing that can actually become real, why not make itconst?PR
constifyingDeref: #145279