Skip to content

Rollup of 8 pull requests - #133339

Merged
bors merged 58 commits into
rust-lang:masterfrom
jieyouxu:rollup-gav0nvr
Nov 22, 2024
Merged

Rollup of 8 pull requests#133339
bors merged 58 commits into
rust-lang:masterfrom
jieyouxu:rollup-gav0nvr

Conversation

@jieyouxu

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

Ralf Jung and others added 30 commits November 10, 2024 16:26
Preparing for merge from rustc
sync support: dont implicitly clone inside the general sync machinery
stacked borrows tests: add those that fail under TB
Renamed `this` to `ecx` in `extern_static`
use -Zroot-dir instead of --remap-path-prefix for diagnostic dir handling
Michael Goulet and others added 11 commits November 22, 2024 03:12
…anieu

re-export `is_loongarch_feature_detected`

r? ``@Amanieu``
…=jhpratt

Support `each_ref` and `each_mut` in `[T; N]` in constant expressions.

Tracking issue: rust-lang#133289

The methods `<[T; N]>::each_ref` and `<[T; N]>::each_mut` can easily be reimplemented to allow marking them with the `const` specifier.

This specific implementation takes a different approach than the original as to avoid using iterators (which are illegal in constant expressions).
Use arc4random of libc for RTEMS target

Switch to the `arc4random` from libc. It is available since libc 0.2.162
…=lcnr

Simplify `fulfill_implication`

calm before the storm
…r=lcnr

Bail in effects in old solver if self ty is ty var

Otherwise when we try to check something like `?t: ~const Trait` we'll immediately stick it to the first param-env candidate, lol.

r? lcnr
library: update comment around close()

r? `@the8472`
… r=joboet

Fix typo in `std::thread::Scope::spawn` documentation.

Just a simple fix for a typo that caught my attention.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Nov 22, 2024
@jieyouxu

ghost commented Nov 22, 2024

Copy link
Copy Markdown
Member Author

@bors r+ rollup=never p=5

@bors

ghost commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 874cf85 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 22, 2024
@bors

ghost commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 874cf85 with merge a475551...

@bors

ghost commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing a475551 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 22, 2024
@bors
bors merged commit a475551 into rust-lang:master Nov 22, 2024
@rustbot rustbot added this to the 1.85.0 milestone Nov 22, 2024
@rust-timer

ghost commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#133238 re-export is_loongarch_feature_detected 9c72991d20faaf00062b882f230e34ce1c6de788 (link)
#133288 Support each_ref and each_mut in [T; N] in constant e… c4faddb07bdbb7b222338a05a3797a1e6d05920d (link)
#133311 Miri subtree update ea37cfc85bb4b43327f34f89053ed1f32664e1b8 (link)
#133313 Use arc4random of libc for RTEMS target 3bc4e8e16652dc17c61690f534220f582a7de9f2 (link)
#133319 Simplify fulfill_implication 364c38399afe19d1d91fd9b8ca0be2b187f20604 (link)
#133323 Bail in effects in old solver if self ty is ty var 5696804d2c1acf93274a6ce03edb7a70b5f70b5f (link)
#133330 library: update comment around close() fe9bebdbe0dac0901465a9a28dd3018dae3cd67a (link)
#133337 Fix typo in std::thread::Scope::spawn documentation. 6754ad66cf0f470c804a710101f7cb64b7e67ec5 (link)

previous master: a7d9ebdf08

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer

ghost commented Nov 22, 2024

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (a475551): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.2%, secondary 1.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
2.2% [2.2%, 2.2%] 1
Regressions ❌
(secondary)
1.4% [1.4%, 1.4%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.2% [2.2%, 2.2%] 1

Cycles

Results (primary -1.1%, secondary 0.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.1% [2.1%, 2.1%] 1
Improvements ✅
(primary)
-1.1% [-1.1%, -1.1%] 1
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 796.689s -> 796.567s (-0.02%)
Artifact size: 335.98 MiB -> 336.13 MiB (0.04%)

@jieyouxu
jieyouxu deleted the rollup-gav0nvr branch November 22, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.