Add mdBook team processes - #1095
Conversation
rustbot
added
the
S-waiting-on-review
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| - You will also be subscribed to the `all@rust-lang.org` and `mdbook@rust-lang.org` mailing lists. | ||
| See [this file](https://github.com/rust-lang/team/blob/HEAD/teams/all.toml) to check how | ||
| subscriptions to mailing lists work. Both are very low-volume mailing list (maybe a few emails per | ||
| year). About `all@rust-lang.org`: it's a way to communicate things to all contributors. We will |
There was a problem hiding this comment.
I would personally not embed emails like this in public docs, just an invitation for more spam to be sent to them.
There was a problem hiding this comment.
Fair enough, removed.
| ### When are FCPs required? | ||
|
|
||
| An FCP will be needed for any stabilization of user-facing changes, like UI/UX changes, | ||
| new command-line arguments, new attributes, etc. |
There was a problem hiding this comment.
You should probably mention breaking changes. Those definitely require an FCP, since mdBook doesn’t have RFCs or a Rust style stability system.
| When starting an FCP, make sure only the relevant subteam is labeled on the issue/PR, to avoid | ||
| pinging people with changes they aren't interested in. | ||
|
|
||
| ### Can I work on code experimentally before a approval is gained? |
There was a problem hiding this comment.
| ### Can I work on code experimentally before a approval is gained? | |
| ### Can I work on code experimentally before an approval is gained? |
| did you pick this design? | ||
|
|
||
| [mdbook]: https://github.com/rust-lang/mdBook/ | ||
|
|
There was a problem hiding this comment.
|
Applied suggestions. |
There was a problem hiding this comment.
This document flows a bit strange to me, and I guess the problem is shared with the rustdoc version as well. Essentially, it seems worded as a path to membership, rather than starting with, what is a member and why would I want to be one?
The one weirdness missing to me is that membership simply says you can merge things, whereas from what you imply, FCPs are also possible as well.
There was a problem hiding this comment.
Added a mention about FCPs in the "What it means to be a mdBook team member" section.
6 participants
I derived it from the rustdoc team processes minus the things that don't apply (like RFCs, although I kept FCPs).
cc @rust-lang/mdbook
Rendered