own_ref RFC initial commit - #4000
Open
CheaterCodes wants to merge 1 commit into
Open
Conversation
Author
|
To create the appropriate cross-links to relevant issues:
|
|
|
||
| Probably the most commonly used unsized types are slices `[T]`. | ||
| Since they cannot be pased by value, they are always passed with indirection. | ||
| We use `&[T]` for read-only slices, `&mut T` for mutable slices. |
Member
There was a problem hiding this comment.
Suggested change
| We use `&[T]` for read-only slices, `&mut T` for mutable slices. | |
| We use `&[T]` for read-only slices, `&mut [T]` for mutable slices. |
| > Boxes provide ownership for this allocation, and | ||
| drop their contents when they go out of scope. | ||
|
|
||
| A `Box<T, Noop<'a>>` is neither a heap allocation, nor does it provide opwnership for its allocation. |
Member
There was a problem hiding this comment.
quotes need to use > on every line. also ownership is misspelled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce owning references
&owninto the language, which allows passing ownership of the pointee without moving its value.Owning references can be moved out of (including partial moves), and drop their pointee when dropped.
Important
Since RFCs involve many conversations at once that can be difficult to follow, please use review comment threads on the text changes instead of direct comments on the RFC.
If you don't have a particular section of the RFC to comment on, you can click on the "Comment on this file" button on the top-right corner of the diff, to the right of the "Viewed" checkbox. This will create a separate thread even if others have commented on the file too.
Rendered