Repository navigation
ci: Resolve most zizmor findings as of zizmor@1.31.1
#1410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+88
−44
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
464031d
ci: Pin `actions/checkout` to 5.1.0 hash
hashcatHitman afe87bf
ci: Replace `dtolnay/rust-toolchain` with `rustup`
hashcatHitman 3e4eef2
ci: Disable credential persistence
hashcatHitman da54868
ci: Expand `matrix.target` in `env`
hashcatHitman 371572c
ci(deps): Bump `actions/checkout` to 7.0.1
hashcatHitman bcb987c
chore: Configure Dependabot to update GitHub Actions
hashcatHitman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| version: 2 | ||
|
|
||
| updates: | ||
| - package-ecosystem: github-actions | ||
| cooldown: | ||
| default-days: 7 | ||
| directory: / | ||
| schedule: | ||
| interval: weekly | ||
| time: "06:00" | ||
| timezone: "Etc/UTC" | ||
| commit-message: | ||
| prefix: ci | ||
| include: scope |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is due to the
template-injectionaudit ofzizmor. Template expansion can be abused or misused in some cases. That obviously isn't the case here, but becausecrabwatchuses thepedanticpersona,zizmorflags all template expansion in code contexts, which it considers code smells.It can be made less repetitive if we move the definition of the
TARGETenvironment variable to the job level, if that's bothering you.