Skip to content

chore: update to cc@1.4.3 - #5259

Merged
RalfJung merged 1 commit into
rust-lang:masterfrom
weihanglo:cc-1.4.3
Aug 17, 2026
Merged

chore: update to cc@1.4.3#5259
RalfJung merged 1 commit into
rust-lang:masterfrom
weihanglo:cc-1.4.3

Conversation

@weihanglo

Copy link
Copy Markdown
Member

With this,
we get C dep remap for free when building in rustc bootstrap:

See

* rust-lang/rust#161049
* rust-lang/cargo#17309
* rust-lang/cc-rs#1794
@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Aug 17, 2026
@weihanglo

Copy link
Copy Markdown
Member Author

I meant, rustc bootstrap already did the remap manually. When it switches to Cargo's -Ztrim-paths, downstream need a newer cc-rs to get the remap working

@RalfJung

Copy link
Copy Markdown
Member

I don't know what a "C dep remap" is. :)

But a cc crate update sounds fine, GH is just too broken atm to even show me the diff.

@weihanglo

Copy link
Copy Markdown
Member Author

I don't know what a "C dep remap" is. :)

For example, if your C (transitive) dependency has a __FILE__ macro, it may expand to absolute paths of the build environment, and get embedded in the final object/executable. Rustc bootstrap currently have a global -fdebub-prefix-map cflag to sanitize this. We are planning to transition to Cargo's -Ztrim-paths, which cc-rs also leverages but require a newer version of cc-rs.

@weihanglo

Copy link
Copy Markdown
Member Author

GH is just too broken atm to even show me the diff.

Like, everyday 😬

@RalfJung
RalfJung added this pull request to the merge queue Aug 17, 2026
@RalfJung

Copy link
Copy Markdown
Member

FWIW that lockfile is only used in this repo, it has no effect at all for builds in r-l/r.

@weihanglo

Copy link
Copy Markdown
Member Author

Hmm…, I thought it was like rust-lang/cargo. Anyway, it should be fine.
Thanks for the review!

@RalfJung

RalfJung commented Aug 17, 2026 via email

Copy link
Copy Markdown
Member

Merged via the queue into rust-lang:master with commit 41656a5 Aug 17, 2026
14 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Waiting for a review to complete label Aug 17, 2026
@weihanglo
weihanglo deleted the cc-1.4.3 branch August 17, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants