Link the blocking IO footnote to the IO chapter - #271
Open
zjncs wants to merge 1 commit into
Open
Conversation
Author
|
The Evidence: the linkcheck failure reports exactly one broken URL: That is the project-goal link in #270 fixes exactly that link. Once it lands, I'm happy to rebase this PR so CI runs green — or I can rebase it on top of #270's branch now if the maintainers prefer. |
zjncs
marked this pull request as ready for review
September 5, 2026 09:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
[^blocking]footnote insrc/intro.mdends with two placeholder links that were never filled in:Both render as
<a href="">chapter TODO</a>— dead links to the page itself — in the published book (2 emptyhref=""anchors in the renderedintro.html).Change
Point the footnote at the existing guide chapter that covers exactly this material, IO and issues with blocking (
src/part-guide/io.md), and merge the two sentence halves into one link since they target the same chapter.Verification
43891ce(tip ofmaster).grep -c 'href=""' book/html/intro.html→2before the change,0after; the footnote now renders as<a href="part-guide/io.html">the IO chapter</a>.mdbook buildon a combined validation branch (this change cherry-picked together with Fix async project goal link #270) completes with exit 0, including thelinkcheck2renderer.mdbook buildon this branch alone failslinkcheck2onsrc/intro.md:55— that is the pre-existing brokenrust-project-goalslink onmaster(the repo was renamed), which is fixed separately in Fix async project goal link #270. It is unrelated to and not caused by this change.Risk
Minimal: one-line documentation fix.
AI assistance disclosure
This patch was prepared by an autonomous AI coding agent at the direction of the account owner.