Commit Cargo.lock to 0.2.x branch - #258
Merged
Merged
Conversation
Per the new Rust recommendation it is now recommended for libraries to commit their `Cargo.lock` too. This can prevent nasty surprises in CI builds - like we already experience because of all versions of `core2` being yanked. To fix this, this commit adds Cargo.lock and removes it from `.gitignore`. Additionally, this adds the `rust-version` field to ensure cargo won't turn version 3 manifest into version 4. (That's the reason that change is in this commit with `Cargo.lock`, not the only motivation behind it.)
Kixunil
force-pushed
the
0.2.x-add-cargo-lock
branch
from
August 28, 2026 20:34
ebd972c to
02feaaf
Compare
Member
|
Perfect, thanks! Normally I'd say we want to rename this to @tcharding if you get a chance can you take this lockfile and integrate it into a "fix CI" PR? Or I can give it a shot, but I may be slow. |
apoelstra
added a commit
that referenced
this pull request
Sep 1, 2026
28d2d46 Bump version to 0.2.3 (Tobin C. Harding) c0acdde Use byte string for asci table (Tobin C. Harding) d12548c CI: Fix pinning (Tobin C. Harding) 02feaaf Commit `Cargo.lock` (Martin Habovstiak) Pull request description: Use Kix's work in #258. Tthen use claude to fix the pinning. The use `clippy` to fix the linting. I just got out of the way. Oh, and bump the version so we can cut a release from this PR. ACKs for top commit: apoelstra: ACK 28d2d46; successfully ran local tests Kixunil: ACK 28d2d46 Tree-SHA512: e0f196993a46e308301bcd4ecefc7ccb9b62777e402000607c5f75df06c0b3b02fa8e499d83684421499cdfff6e89c9dde4bbe83d90db20d89a752e67e451259
Collaborator
Author
|
@apoelstra I went for a minimal fix to get CI to work and was thinking of doing the switching as a potential followup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the new Rust recommendation it is now recommended for libraries to commit their
Cargo.locktoo. This can prevent nasty surprises in CI builds - like we already experience because of all versions ofcore2being yanked.To fix this, this commit adds Cargo.lock and removes it from
.gitignore.For future reference, this is how you can force download of a yanked crate:
Now you know the hash, so manually add an entry to Cargo.lock just like the others that already are there. - Don't forget to add the package to
dependenciesaside from[[package]]section. Just a warning, don't make a typo; I wasted a bunch of minutes because cargo didn't say "sourve" was an invalid key and just complained about yanking. (I was about to ask a clanker and got the word underlined after copying so that made me notice. :D)