Patch sub-errors to make them backwards compatible - #257
Conversation
|
This PR needs to be API addition only, please review accordingly. |
We would like to alias the `DecodeFixedLengthBytesError` back into `0.2` and `0.3` as `HexToArrayError` [0]. During the 1.0 dev cycle we made a few minor API breaks. Turns out we were probably overly savage and the benefits of re-instating the previous API outweigh the maintenance risks we were attempting to mitigate. Put the `InvalidLengthError` and `InvalidCharError` back to how they were when in the `0.3` release. [0] See issue rust-bitcoin#254 for full context and justification.
aa86a4c to
f8cbe86
Compare
|
We have API files here -- can you patch those to make CI happy? |
|
Ah, I see, it needs a specific old version of cargo-rbmt. I'll just do it. You now need to ACK because Github thinks the PR is mine. |
lol, I'm a goose. I will set up a bunch of |
|
ACK 828b93d |
|
Just needs a release PR now :).
You can just run |
|
Nice, thanks. |
|
@tcharding are you willing to make a release PR off |
|
Yep can do. |
We would like to alias the
DecodeFixedLengthBytesErrorback into0.2and0.3asHexToArrayError[0].During the 1.0 dev cycle we made a few minor API breaks. Turns out we were probably overly savage and the benefits of re-instating the previous API outweigh the maintenance risks we were attempting to mitigate.
Put the
InvalidLengthErrorandInvalidCharErrorback to how they were when in the0.3release.Done as part of #254
[0] See issue #254 for full context and justification.