Repository navigation
Conversation
When a code block has a name, set RUNME_NAME to it in the process environment for both the v1 and v2 runner services. The variable is only set for the process and is not stored in the session. Blocks without a name do not get the variable. Signed-off-by: Srinivas Chippagiri <cvas22@gmail.com>
sourishkrout
self-requested a review
October 26, 2026 19:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1225
Code blocks that have a name now get it as
RUNME_NAMEin the process environment, so tasks started from a cell can link back to the cell that launched them.runnerand v2runnerv2service), from the existingKnownNameof the execute request.The issue suggests
RUNME_CELL_NAME, but the maintainer comment there saysRUNME_NAMEwas the likelier choice pending a collision check. I grepped the repo and found no existing use ofRUNME_NAME, so I went with that. Happy to rename if you prefer the other.Tests: added
Test_runnerService/ExecuteKnownNameEnvandTestRunnerServiceServerExecute_KnownNameEnv, both pass on Linux. The remaining failures in./runner,./runnerv2serviceand./command(JavaScript, Deno, Ruby, direnv and similar) happen onmaintoo because those tools are missing in my environment.