fix(0223): no duration alarm for supply, whose run length is a budget - #318
Merged
stkrolikiewicz merged 1 commit intoSep 15, 2026
Merged
Conversation
…dget Measured before the first deploy of #317: supply's Duration.Maximum is ~240.5 s every run, because its Horizon walk stops at DEFAULT_TIME_BUDGET_SECS = 240 (task 0084) against a 300 s timeout — exactly the 80% threshold the duration alarm uses. Deployed as merged, the new supply-duration-near-timeout alarm would have latched on its second evaluation and been re-surfaced by the 0214 digest daily: the failure 0223 exists to remove, self-inflicted. addWorkerHealthAlarms gains noDurationAlarm, set to the reason, which skips the duration alarm and leaves liveness untouched. Alarm strip 54 -> 53.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Duration.Maximumis ~240.5 s every single run, because its Horizon walk stops atDEFAULT_TIME_BUDGET_SECS = 240(task 0084) against a 300 s timeout — exactly the 80% thresholdaddWorkerHealthAlarmsuses. Deployed as merged,supply-duration-near-timeoutwould have latched on its second evaluation and been re-surfaced by the 0214 digest every day: the failure 0223 exists to remove, self-inflicted.WorkerHealthAlarmProps.noDurationAlarm?: string— set to the reason — skips the duration alarm for a worker whose run length is a budget rather than a symptom. Same pattern asWORKERS_WITHOUT_HEALTH_ALARMS: the exception is data with a reason, not a comment. Liveness (-no-invocations) is unaffected.verify-dashboardpasses. Nothing else changes.#317 is merged but not yet deployed; this goes out with it in one Observability deploy.