🎨 Palette: interactive navigation, dynamic title, and keyboard shortcuts#222
Draft
ruhdevops wants to merge 4 commits into
Draft
🎨 Palette: interactive navigation, dynamic title, and keyboard shortcuts#222ruhdevops wants to merge 4 commits into
ruhdevops wants to merge 4 commits into
Conversation
This PR implements several micro-UX and accessibility improvements:
1. **Back-to-Top Navigation**: The navbar brand logo now functions as a "Back to Top" trigger.
- Added `id="navbarBrand"`, `role="button"`, `tabindex="0"`, and `aria-label="Ruh Al Tarikh - Back to Top"`.
- Implemented smooth-scroll logic and mobile menu auto-close in `js/app.js`.
2. **Dynamic Document Title**: The browser tab title now updates to the current video title when a modal is open, improving tab management and screen reader context.
3. **Keyboard Shortcuts Discovery**:
- Added 'S' (Share) and 'N' (Notes) shortcuts to the video modal.
- Updated button `title` attributes in `index.html` to hint at these shortcuts (e.g., "Share (S)", "Notes (N)").
4. **Code Quality**: Cleaned up 7 redundant, duplicated blocks of `episodesNavBtn` event listeners in `js/app.js` to improve maintainability.
♿ Accessibility:
- Semantic roles and labels added to brand logo.
- Keyboard support for all new interactions.
- Screen reader friendly tab titles.
Co-authored-by: ruhdevops <203426218+ruhdevops@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
ytstudio | 1409279 | Jul 13 2026, 05:35 AM |
Contributor
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ❌ Deployment failed View logs |
ytstudio | 1409279 | Jul 13 2026, 05:35 AM |
❌ Deploy Preview for ytr-studio failed.
|
✅ Deploy Preview for elegant-seahorse-d9d460 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This PR implements several micro-UX and accessibility improvements:
1. **Back-to-Top Navigation**: The navbar brand logo now functions as a "Back to Top" trigger.
- Added `id="navbarBrand"`, `role="button"`, `tabindex="0"`, and `aria-label="Ruh Al Tarikh - Back to Top"`.
- Implemented smooth-scroll logic and mobile menu auto-close in `js/app.js`.
2. **Dynamic Document Title**: The browser tab title now updates to the current video title when a modal is open, improving tab management and screen reader context.
3. **Keyboard Shortcuts Discovery**:
- Added 'S' (Share) and 'N' (Notes) shortcuts to the video modal.
- Updated button `title` attributes in `index.html` to hint at these shortcuts (e.g., "Share (S)", "Notes (N)").
4. **Code Quality**: Cleaned up 7 redundant, duplicated blocks of `episodesNavBtn` event listeners in `js/app.js` to improve maintainability.
♿ Accessibility:
- Semantic roles and labels added to brand logo.
- Keyboard support for all new interactions.
- Screen reader friendly tab titles.
Co-authored-by: ruhdevops <203426218+ruhdevops@users.noreply.github.com>
This PR implements several micro-UX and accessibility improvements:
1. **Back-to-Top Navigation**: The navbar brand logo now functions as a "Back to Top" trigger.
- Added `id="navbarBrand"`, `role="button"`, `tabindex="0"`, and `aria-label="Ruh Al Tarikh - Back to Top"`.
- Implemented smooth-scroll logic and mobile menu auto-close in `js/app.js`.
2. **Dynamic Document Title**: The browser tab title now updates to the current video title when a modal is open, improving tab management and screen reader context.
3. **Keyboard Shortcuts Discovery**:
- Added 'S' (Share) and 'N' (Notes) shortcuts to the video modal.
- Updated button `title` attributes in `index.html` to hint at these shortcuts (e.g., "Share (S)", "Notes (N)").
4. **Code Quality & Build Fix**:
- Cleaned up redundant event listeners in `js/app.js`.
- Fixed pre-existing syntax errors in renderProjects causing build failures.
♿ Accessibility:
- Semantic roles and labels added to brand logo.
- Keyboard support for all new interactions.
- Screen reader friendly tab titles.
Co-authored-by: ruhdevops <203426218+ruhdevops@users.noreply.github.com>
This PR implements several micro-UX and accessibility improvements while fixing pre-existing build failures:
1. **Back-to-Top Navigation**: The navbar brand logo now functions as a "Back to Top" trigger.
- Added `id="navbarBrand"`, `role="button"`, `tabindex="0"`, and `aria-label="Ruh Al Tarikh - Back to Top"`.
- Implemented smooth-scroll logic and mobile menu auto-close in `js/app.js`.
2. **Dynamic Document Title**: Browser tab title now updates to show the video title when a modal is open, improving tab management and screen reader context.
3. **Keyboard Shortcuts Discovery**:
- Added 'S' (Share) and 'N' (Notes) shortcuts to the video modal.
- Updated button `title` attributes in `index.html` to hint at these shortcuts (e.g., "Share (S)", "Notes (N)").
4. **Build Stability & Cleanup**:
- Resolved pre-existing syntax errors in renderProjects and cleaned up a significant amount of duplicated/corrupt code blocks in js/app.js.
- Removed redundant event listeners.
♿ Accessibility:
- Semantic roles and labels added to brand logo.
- Keyboard support for all new interactions.
- Screen reader friendly tab titles.
Co-authored-by: ruhdevops <203426218+ruhdevops@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented interactive navigation, dynamic document title management, and new keyboard shortcuts for a more professional and accessible experience.
PR created automatically by Jules for task 8041799870949056975 started by @ruhdevops