Merged
Conversation
The test was intermittently failing with "expected Category.count to have changed by -1, but was changed by 0" when run in the full suite. Without an explicit Accept: text/html header, format negotiation pollution from preceding specs (e.g. JSON-format requests) could cause Rails to mishandle the request, preventing the destroy from completing. This is the same root cause as #1470 (people_search_spec). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1477
What is the goal of this PR and why is this important?
Categories as an admin DELETE destroy destroys categoryexpected Category.count to have changed by -1, but was changed by 0How did you approach the change?
(category_type_id, position)on the categories table is incompatible with thepositioninggem. During destroy/update, the gem temporarily sets position to 0 viaupdate_all. If another record in the same scope already has position 0 (from an interrupted prior operation), MySQL raisesActiveRecord::RecordNotUnique, causingdestroy!to failAnything else to add?
destroy!raisesActiveRecord::RecordNotUnique🤖 Generated with Claude Code