Allow time inputs to be filled with time strings#306
Open
Draiken wants to merge 1 commit intorubycdp:mainfrom
Open
Allow time inputs to be filled with time strings#306Draiken wants to merge 1 commit intorubycdp:mainfrom
Draiken wants to merge 1 commit intorubycdp:mainfrom
Conversation
|
Just yesterday I moved from selenium to cuprite and I got some failed tests because of this. Had no idea a Time object was needed for the |
Author
|
@albiere after creating the PR and having previously searched for this in the issues, I noticed there are other PRs doing similar changes. All from long ago, with little/no feedback. The GH actions fail with an unrelated issue. I'm afraid this project is not active anymore or maybe the maintainers are on vacation. All this to say that we shouldn't expect this to be merged any time soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows us to use time strings like
10:00as values for atimeinput.I've spent a lot of time thinking I had a bug because a simple
fill_in "time_field", with: "10:00"didn't work. It seems to expect a time object only but that's not mentioned anywhere AFAIK.This adds the ability to set times as strings which would work normally in JS
element.value = "10:00"