Repository navigation
🐛 Allow SequenceSet#slice length to be zero - #781
Merged
Merged
Conversation
When length is zero, `#slice` will behave similarly to `Array#slice`: it returns an empty set when starting index is in range and `nil` when the starting index is out of range. But, "in range" is defined as `start.abs <= cardinality`, which includes `start == cardinality`. So: ```ruby set[set.cardinality] => nil set[set.cardinality..] => SequenceSet.empty set[set.cardinality.succ..] => nil ```
nevans
added this pull request to stack #775
October 10, 2026 03:16
Base automatically changed from
sequence_set/fix-slice-subset-with-invalid-start-index
to
master
October 10, 2026 03:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When length is zero,
#slicewill behave similarly toArray#slice: it returns an empty set when starting index is in range andnilwhen the starting index is out of range.But, "in range" is defined as
start.abs <= cardinality, which includesstart == cardinality. So: