fix(hooks/rewrite): restore php passthrough rewrite#1983
Conversation
|
Quick status note for whoever picks this up — no rush. The earlier CI run failed on Branch is Thanks! |
|
Reviewer guide to reduce review time: Expert lens: rewrite registry / interpreter passthrough. This restores the missing Suggested review checks:
|
f3d4100 to
21a938d
Compare
|
Hello, i do not really understand on what filter does this php rule wire to Did you really tried php and inspect RTK history to ensure token gains and php being filtered ? This seems very unlikely |
Restore the hook rewrite for bare php commands so issue rtk-ai#1892 gets RTK history/tracking again, but do not claim a PHP filter exists. There is no built-in PHP TOML or Rust filter on this branch, so classify php as passthrough with 0% estimated savings. The rewrite still routes php, php artisan, and php script.php through rtk php, while adjacent tools such as phpunit remain untouched. Tests: cargo fmt --all -- --check; cargo test --bin rtk php -- --nocapture; cargo test --bin rtk; cargo clippy --all-targets -- -D warnings
21a938d to
a319285
Compare
|
Verified and updated in a319285. This PR now treats |
Summary
phpcommands sophp,php artisan ..., andphp script.phproute throughrtk phpagain for RTK history/tracking.phpas passthrough with0.0estimated savings because this branch has no built-in PHP TOML/Rust filter.phpunit,phpcs, andphpstanare not stolen by the interpreter rule.Reviewer Note
This PR does not add PHP output filtering or token savings. Runtime check with a fake
phpbinary confirmsRTK_TOML_DEBUG=1 rtk php demoreports no TOML filter match, thenrtk gain --historyrecordsrtk fallback: php demowith 0 saved tokens.A real PHP/Artisan filter should be a separate PR with concrete sample outputs and savings evidence.
Fixes #1892
Tests
cargo fmt --all -- --checkcargo test --bin rtk php -- --nocapturecargo test --bin rtkcargo clippy --all-targets -- -D warnings