fix(risks): widen toolbar select triggers to prevent dropdown overlap - #1992
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adjusts the Risks tab toolbar select trigger widths so opening a dropdown (notably “Owner”) doesn’t visually overlap adjacent selects.
Changes:
- Replaced
w-fiton the Owner/Status/Risk level select triggers with fixed Tailwind widths (w-36/w-30).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b1ink0
requested changes
Aug 6, 2026
b1ink0
left a comment
b1ink0
left a comment
Collaborator
There was a problem hiding this comment.
Update submodule after PR rtCamp/frappe-ui-react#325 is merged and request a re-review.
b1ink0
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Owner/Status/Risk level selects in the Risks tab toolbar used w-fit, sizing the trigger to its placeholder text while the dropdown grew to fit its widest option - so the Owner dropdown (e.g. "All owners") visually overlapped the adjacent Status select.
Sets fixed trigger widths and opts each select into the new matchTriggerWidth prop (added in the frappe-ui-react bump) so every dropdown is capped to its own trigger's width instead of expanding past it.
Screenshot/Screencast
Checklist
Fixes #1968