ci: install rtcamp app so business unit and feedback tests run - #1966
Closed
HarishChandran3304 wants to merge 2 commits into
Closed
ci: install rtcamp app so business unit and feedback tests run#1966HarishChandran3304 wants to merge 2 commits into
HarishChandran3304 wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Updates the CI unit test workflow to fetch and install the rtcamp app (and its dependency) so Business Unit / Customer Feedback-related tests can run.
Changes:
- Adds
helpdeskas a required dependency forrtcampduring app fetch/install in CI. - Fetches the private
rtcampapp repo using a GitHub secret token and installs it on the test site.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| bench get-app frappe_gmail_thread https://github.com/rtCamp/frappe-gmail-thread --branch version-16 --skip-assets | ||
| bench get-app frappe_comment_xt https://github.com/rtCamp/frappe-comment-xt --branch version-16-hotfix --skip-assets | ||
| # private repo: owns the Business Unit and Customer Feedback doctypes the team/feedback tests need | ||
| bench get-app rtcamp https://rtbot:${{ secrets.RTBOT_TOKEN }}@github.com/rtCamp/erp-rtcamp --branch version-16-hotfix --skip-assets |
| bench get-app erpnext --branch version-16 --skip-assets | ||
| bench get-app hrms --branch version-16 --skip-assets | ||
| # required_app of rtcamp | ||
| bench get-app helpdesk --branch main --skip-assets |
Comment on lines
+68
to
+71
| bench get-app rtcamp https://rtbot:${{ secrets.RTBOT_TOKEN }}@github.com/rtCamp/erp-rtcamp --branch version-16-hotfix --skip-assets | ||
| bench get-app next_pms "$GITHUB_WORKSPACE" --skip-assets | ||
| bench new-site --db-root-password root --admin-password admin --no-mariadb-socket test_site | ||
| bench --site test_site install-app erpnext hrms frappe_gmail_thread frappe_comment_xt next_pms | ||
| bench --site test_site install-app erpnext hrms helpdesk frappe_gmail_thread frappe_comment_xt rtcamp next_pms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relevant Technical Choices
Testing Instructions
Additional Information:
Screenshot/Screencast
Checklist
Fixes #