Fix/1783 (feedback): prevent error when editing child comment after parent deletion - #1786
Open
MusaleTejas wants to merge 1709 commits into
Open
Fix/1783 (feedback): prevent error when editing child comment after parent deletion#1786MusaleTejas wants to merge 1709 commits into
MusaleTejas wants to merge 1709 commits into
Conversation
Feature: Notifications tray and widget
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
…ing to the current view
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
* feat: Timesheet Rejection Reason * chore: remove holiday list from tests setup
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
Signed-off-by: ayushnirwal <53055971+ayushnirwal@users.noreply.github.com>
…to feat/redesign
fix: team allocation page QA issues
…disambiguation Improve customer abbreviation generation and collision handling
…source allocation
QA Fix: Updating a filtered time entry reveals tasks excluded by the active search filter
feat: validate resource allocation against cancelled projects and disabled customers
feat: block overlapping allocation
* feat: timesheet api returns the rejected reason * chore: generalize tests
When a project is chosen in the add/edit allocation modal, the employee combobox now only lists that project's shared members (same DocShare-based membership the project sidebar uses) instead of every employee.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a parent comment is deleted, its child comments are elevated in the hierarchy. However, their
custom_reply_tofield in the database remains pointed to the now-deleted parent comment. This dangling reference causes a validation error (database integrity check) when trying to edit the child comment later.This PR resolves the issue by:
on_trashdoc_event handler for theCommentDocType.custom_reply_topointer updated to the deleted comment's own parent (or set toNoneif it was a root comment), cleaning up the dangling references.