chore: restyle new examples-shiny apps#4004
Merged
Merged
Conversation
cpsievert
requested changes
Mar 21, 2024
cpsievert
left a comment
cpsievert
left a comment
Collaborator
There was a problem hiding this comment.
Looks like something went wrong with the git history?
Member
Author
Yeah I was going to roll this into #4003 before merging |
gadenbuie
force-pushed
the
chore/examples-code-style
branch
from
March 21, 2024 18:07
b201264 to
4c22b13
Compare
gadenbuie
force-pushed
the
chore/examples-code-style
branch
from
March 21, 2024 18:08
4c22b13 to
b4cc60c
Compare
Member
Author
|
@cpsievert okay, merge conflicts are fixed now |
cpsievert
reviewed
Mar 21, 2024
|
|
||
| # Sidebar panel for inputs ---- | ||
| sidebar = sidebar( | ||
|
|
Collaborator
There was a problem hiding this comment.
I'm confused as to why this newline got removed, but it didn't in 01_hello?
Member
Author
There was a problem hiding this comment.
I did attempt to add code changes and restore the newlines manually but it was a bit of work so I bailed. So I probably introduced the difference in this line.
Collaborator
I think I'd prefer that. |
Member
Author
|
@cpsievert okay (most of the useful) newlines are back |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-styles the example apps using
grkstyle::grk_style_dir("inst/examples-shiny")(powered bystylerand using the tidyverse style rules, with an exception for the style described here).This did have the effect of removing some leading empty lines between the open
(of a function call and the next comment. I don't think this affects readability, but we could add these newlines back if desired.Note: stacks on top of #4003. We can merge this into #4003 so we can merge the examples changes all at once.