Dont sign when advancing blockchain

[julia-zack]

No description provided.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

[julia-zack]

differentiating RRE from log level (info instead of error)

[Copilot]

Pull request overview

This PR tightens PowHSM release-signing behavior by enforcing “ancestor in position” requirements directly in ReleaseRequirementsEnforcer, and preventing signing when the HSM is busy updating its blockchain bookkeeping state (advance/update in progress). It also simplifies the requirements enforcement flow by removing the separate AncestorBlockUpdater component and renaming the HSM bookkeeping state getter for clarity.

Changes:

• Refactor release requirements enforcement to use BlockStore + HSMBookkeepingClient directly, including explicit validation for “HSM in progress” and “target block not yet informed”.
• Update BTC release signing to resolve and cache signer/HSM version during setup(), and to skip signing when requirements enforcement indicates the HSM is busy.
• Rename HSMBookkeepingClient.getHSMPointer() to getPowHSMState() and update call sites and tests; remove AncestorBlockUpdater and its tests, replacing coverage with expanded ReleaseRequirementsEnforcerTest.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
src/main/java/co/rsk/federate/signing/hsm/requirements/ReleaseRequirementsEnforcer.java	Moves ancestor-update logic and validations into the enforcer; now interacts with BlockStore + HSMBookkeepingClient directly.
src/main/java/co/rsk/federate/signing/hsm/requirements/AncestorBlockUpdater.java	Deleted; functionality absorbed into ReleaseRequirementsEnforcer.
src/main/java/co/rsk/federate/signing/hsm/client/HSMBookkeepingClient.java	Renames bookkeeping state getter to getPowHSMState().
src/main/java/co/rsk/federate/signing/hsm/advanceblockchain/HsmBookkeepingClientImpl.java	Implements getPowHSMState() and updates internal validation to use it.
src/main/java/co/rsk/federate/signing/hsm/advanceblockchain/HSMBookkeepingService.java	Switches bookkeeping state reads to getPowHSMState().
src/main/java/co/rsk/federate/signing/hsm/HSMClientException.java	Narrows constructor visibility to protected for controlled subclassing.
src/main/java/co/rsk/federate/FedNodeRunner.java	Updates wiring to construct ReleaseRequirementsEnforcer without AncestorBlockUpdater.
src/main/java/co/rsk/federate/btcreleaseclient/BtcReleaseClient.java	Caches signer version during setup; skips signing when enforcer blocks due to HSM state; renames pegout readiness helper for inverted logic.
src/test/java/co/rsk/federate/signing/hsm/requirements/ReleaseRequirementsEnforcerTest.java	Adds comprehensive tests for multiple PowHSM enforcement scenarios and ancestor update payload behavior.
src/test/java/co/rsk/federate/signing/hsm/requirements/AncestorBlockUpdaterTest.java	Deleted along with AncestorBlockUpdater.
src/test/java/co/rsk/federate/signing/hsm/advanceblockchain/HSMBookkeepingServiceTest.java	Updates tests to use getPowHSMState().
src/test/java/co/rsk/federate/signing/hsm/advanceblockchain/HsmBookkeepingClientImplTest.java	Updates tests to use getPowHSMState().
src/test/java/co/rsk/federate/btcreleaseclient/BtcReleaseClientTest.java	Adjusts setup stubbing to account for version resolution during BtcReleaseClient.setup().

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[sonarqubecloud]

Quality Gate passed

Issues
99 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.8% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/main/java/co/rsk/federate/signing/hsm/requirements/ReleaseRequirementsEnforcer.java:130

• getHeadersToUpdateAncestor treats “starting point is current best block” as startingBlockNumber == targetBlockNumber, but that ignores forks at the same height. If the HSM best block is on a different branch with the same height, this will incorrectly send only the target header instead of failing fast (or building a verifiable path), potentially resulting in a bad update attempt and misleading logs.

Consider also requiring startingPoint.getHash().equals(targetBlock.getHash()) for this fast path; otherwise throw an HSMBlockchainBookkeepingRelatedException (chain mismatch) before calling updateAncestorBlock.

        if (startingBlockNumber == targetBlockNumber) {
            logger.trace(
                "[getHeadersToUpdateAncestor] Target block is current best block. " +
                    "Will update ancestor with target block header only"
            );