Repository navigation
feat: dashboard alert filters (involvement, team, service) - #124
NisargPipaliya wants to merge 3 commits into
Conversation
- /alerts and /teams OpenAPI endpoints + schemas for dashboard filtering - alerts_repo / alerts_view involvement filtering support - Dashboard UI (filters panel), overview CSS and i18n - Tests for the involvement filter and teams API
|
/sign-cla |
…d.html - Add create_incident_responder / create_incident_stakeholder (and the IncidentResponder / IncidentStakeholder model imports) to tests/factories.py; test_alerts_involvement_filter.py imports them and the merge from main did not carry them (they originated on the slack-mentions branch). - Fix the main-merge of dashboard.html: collapse the duplicated first-div-page-layout wrapper into one and remove a stray Recent-card header that was spliced inside the Impacted-services card, which left two unclosed <div>s and a mismatched </section>. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Thanks for the contribution! The filtering functionality is useful, especially the ability to focus on alerts where the current user is involved. However, I think the current implementation needs some UX improvements and a technical fix before merging. 1. Simplify the Dashboard UXThe Dashboard already contains multiple summary cards, charts, active alerts, service impact, and recent activity. Adding a permanently visible filter card at the top makes the interface more crowded and pushes important operational information further down the page. I'd suggest the following changes:
The goal is to keep the Dashboard focused on providing a quick operational overview, while allowing users to narrow down their personal workload when needed. 2. Fix the AlertGroup API endpoint (blocking)In apiGet("/api/alerts?" + params.join("&"), ...);However, since IncidentRelay 2.3, the correct endpoint is: The old Please update:
The existing 3. Verify the updated behaviorPlease add or update tests to cover:
Overall, I support the feature and the backend filtering approach. I would just prefer a more compact, context-specific UX that follows IncidentRelay's existing interface patterns. Please address the UX changes and the API endpoint issue before merging. Thanks again for your work on this! |
Summary
Testing
Issue: #123