[ntuple] Throw exception if appended file is not writable #20908
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 16h 5m 12s ⏱️ For more details on these failures, see this check. Results for commit 4e0b655. ♻️ This comment has been updated with latest results. |
hahnjo
requested changes
Jan 19, 2026
Member
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
Can you please also fix this for RNTupleParallelWriter?
silverweed
force-pushed
the
rntuple_append_samename
branch
from
91b357b to
22e7b9d
Compare
silverweed
force-pushed
the
rntuple_append_samename
branch
from
22e7b9d to
1bd74a5
Compare
hahnjo
approved these changes
Jan 19, 2026
instead of crashing
silverweed
force-pushed
the
rntuple_append_samename
branch
from
1bd74a5 to
4e0b655
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of crashing.
Checklist: