feat: Bank Sync Connector Architecture ($500 bounty)#1172
Open
jeromeyhq wants to merge 1 commit into
Open
Conversation
Pluggable architecture for bank integrations with: - Abstract BankConnector base class (interface) - connect() / disconnect() lifecycle - import_transactions() for bulk import - refresh() for incremental sync - get_accounts() and health_check() - Mock connector with realistic test data - 3 accounts (checking, savings, credit) - 5 categories: groceries, dining, transport, shopping, bills + income - Deterministic transaction generation (same seed = same data) - ~90 days of realistic transaction history - Connector registry for pluggable discovery - register_connector() decorator - get_connector() / list_connectors() API - Auto-registration of built-in connectors - REST API routes: - GET /api/bank-sync/connectors — List available connectors - GET /api/bank-sync/accounts — List bank accounts - POST /api/bank-sync/import — Bulk import transactions - POST /api/bank-sync/refresh — Incremental refresh - GET /api/bank-sync/health — Health check - Full test suite (pytest) covering base, mock, registry Python 3.9 compatible (no 3.10+ type syntax).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bank Sync Connector Architecture
Pluggable architecture for bank integrations as specified in #75.
What this delivers
BankConnectorbase class withconnect(),disconnect(),import_transactions(), andrefresh()methodsFiles added
app/services/connectors/base.pyBankConnectorinterface +TransactionRecord,AccountInfo,SyncResultdataclassesapp/services/connectors/mock_connector.pyapp/services/connectors/registry.pyregister_connector(),get_connector(),list_connectors()app/routes/bank_sync.py/api/bank-sync/{connectors,accounts,import,refresh,health}tests/test_connectors.pyAPI Endpoints
Usage example
Design notes
BankConnectorand use@register_connectorAll 5 Python files compile cleanly. Tests included.