feat: goal-based savings tracking & milestones#1157
Draft
cyrillical00 wants to merge 1 commit into
Draft
Conversation
Closes rohitdash08#133 - SavingsGoal model with target/current/currency/deadline fields - REST API: GET/POST /savings, GET/PATCH/DELETE /savings/:id, POST /savings/:id/contribute - Status computation: completed/on-track/ahead/behind based on progress vs deadline - Monthly target calculation based on remaining amount and months to deadline - Goals are scoped per user (JWT-authenticated) - React frontend: Budgets page loads real savings goals via API - API client in app/src/api/savings.ts - 17 passing tests (fakeredis for test isolation)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133
Summary
SavingsGoalSQLAlchemy model withtarget_amount,current_amount,currency,deadlinefields/savings: list, create, get, update, delete goals; contribute amountscompleted/on-track/ahead/behind) based on progress relative to deadlineBudgets.tsxloads real savings goals from the API (with loading/empty states)app/src/api/savings.tsfakeredisfor Redis isolationTest plan
cd packages/backend && python -m pytest tests/test_savings.py -v→ 17 passedstatusflips tocompletedwhen current >= target