Add list sort builtins using a new ordering API#9832
Draft
jrrrp wants to merge 4 commits into
Draft
Conversation
bb4d55e to
e8d2bed
Compare
This presumes that types by convention will implement a default_cmp method, if it makes sense to have a default sort. This could make sense for Integers, Tuples (lexicographic sort), and Dec. Str for example will not, as there is no good default sort for strings that is sensitive to different locales, or different string content (e.g., strings containing numbers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion in Zulip^1 this PR
t.default_cmp : t, t -> [FirstBeforeSecond, Equivalent, SecondBeforeFirst]Testing
Todo
Before I finish I thought I'd check that the naming is still ok:
In particular,
sort_with_default_revis quite verbose, and if you want to define a comparison function inline, it looks like this:[1] https://roc.zulipchat.com/#narrow/channel/304641-ideas/topic/Sorting.20tuples.3F/with/606333839
https://roc.zulipchat.com/#narrow/channel/304641-ideas/topic/List.20sort.20builtins/with/605016649