Skip to content

Fix diagonal lines in annotation loading spinners - #134

Merged
lucas-fochesatto merged 4 commits into
mainfrom
lucas/fix-annotation-loading-spinner
Oct 12, 2026
Merged

lucas-fochesatto merged 4 commits into
mainfrom
lucas/fix-annotation-loading-spinner

Conversation

@lucas-fochesatto

@lucas-fochesatto lucas-fochesatto commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fix the stray diagonal line in annotation loading spinners during Smart Polygon conversion by starting each arc on a separate drawing path.

Type of Change

  • Bug fix

Validation

  • Tests added or updated where behavior changed
  • Screenshots or recording attached for visual changes
  • 33 focused renderer tests passed, including real Pixi geometry at two zoom levels.
  • Typecheck, lint, formatting, and browser package build passed.
  • Browser comparison verified the diagonal line disappears.

Annotation loading spinners before and after the fix

Notes For Reviewers

No public API changes. Roboflow can consume the fix after a package release.

@lucas-fochesatto
lucas-fochesatto requested a review from a team as a code owner October 8, 2026 12:50
Comment thread docs/internal/assets/annotation-loading-spinner-before-after.jpg Outdated

@digaobarbosa digaobarbosa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove the before after image

@digaobarbosa digaobarbosa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucas-fochesatto
lucas-fochesatto merged commit 004062b into main Oct 12, 2026
3 checks passed
@lucas-fochesatto
lucas-fochesatto deleted the lucas/fix-annotation-loading-spinner branch October 12, 2026 15:49
@lucas-fochesatto lucas-fochesatto mentioned this pull request Oct 12, 2026
7 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants