chore: sync Noct upstream#29
Conversation
- Implement tests for the OAuth token route to ensure proper handling of public clients, PKCE verification, and error serialization. - Create tests for the remote MCP HTTP architecture to validate server timing without triggering OAuth rate limits. - Introduce tests for server timing metrics to confirm correct duration reporting. - Add tests for the Supabase OAuth store to verify authorization code exchanges, refresh token rotations, and legacy token verifications. - Establish tests for the operation activity store to ensure client name resolution and fallback mechanisms. - Implement a script to check for client secret leaks in built artifacts. - Add SQL migrations to enhance security and manage OAuth consent requests and rate limits. - Schedule a cron job for purging expired security events in the database.
… for enhanced OAuth security event tracking
# Conflicts: # tests/browser/mcp-activity/mcp-activity.spec.ts # tests/browser/mcp-activity/supabase-fixture.mjs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df63c8de84
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const previewBlockUrl = new URL("../preview/PreviewBlock.tsx", import.meta.url); | ||
| const previewPaneUrl = new URL("../preview/PreviewPane.tsx", import.meta.url); | ||
|
|
||
| test("Canvas cursor escapes arbitrary MotionDoc node IDs and retries bounded DOM lookup", async () => { |
There was a problem hiding this comment.
This new test file lives under features/pitch/ui/hooks, but the npm test script only expands features/pitch/application/*.test.ts, features/pitch/infrastructure/*.test.ts, and other non-UI globs. As a result, these cursor architecture assertions are skipped when CI or contributors run the standard test command, so regressions in the new MCP cursor behavior can land unnoticed; add this path to the test script or move the test under a covered glob.
Useful? React with 👍 / 👎.
2 participants
Summary
mainthrough8f1f3c3, including the Remote MCP OAuth/security and Canvas activity updatesVerification
npm test(204 passed)npx tsc --noEmitnpm run lintnpm run test:agent(12 passed)npm run buildnpm run build:scan-secretsCI=1 npm run test:agent:e2e(19 passed)The resulting tree is byte-identical to the branch proposed to Noct upstream.