fix(ios): remove Xcode 26 modulemap stripping workaround#239
Merged
mfazekas merged 1 commit intofeat/rive-ios-experimentalfrom May 4, 2026
Merged
Conversation
No longer needed since RiveRuntime XCFramework switched from C++/ObjC++ interop to C/ObjC interop — the generated Swift header no longer contains swift:: namespace types that caused ODR conflicts across Xcode versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the workaround that stripped the
RiveRuntime.Swiftsubmodule from modulemaps to avoid ODR conflicts. No longer needed since the upstream XCFramework switched from C++/ObjC++ interop to C/ObjC interop — the generated Swift header no longer emitsswift::namespace types.Tested building with both Xcode 16.4 and Xcode 26.2 with the unstripped modulemap — no ODR errors.
Note: This PR depends on a RiveRuntime XCFramework built with C/ObjC interop. If the build fails with ODR errors like
'swift::Optional::init' has different definitions in different modules, the workaround still needs to be re-added (revert this PR). You can verify by checkinggrep -c 'namespace swift' RiveRuntime-Swift.h— it should be 0.