fix(ios): pass fit in constructor, OOB asset improvements#237
Merged
mfazekas merged 2 commits intofeat/rive-ios-experimentalfrom Apr 29, 2026
Merged
Conversation
Passes fit directly in the Rive() constructor instead of setting it after creation. Removes the layoutSubviews workaround since rive-ios 6.19.1 fixes the MTKView drawable timing issue (rive-ios#443).
… to OOB example Experimental backend logs a warning when updateReferencedAssets is called since the concurrency API cannot update already-bound artboard assets. Add explicit type fields to OutOfBandAssets example to suppress inference warnings. Bundle kanit_regular.ttf font in expo examples via expo-font.
mfazekas
force-pushed
the
fix/fit-constructor-and-oob-assets
branch
from
34a43f2 to
0ef84aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fit:directly inRive()constructor instead of setting it post-creation. Removes thelayoutSubviews/pendingFitworkaround since rive-ios 6.19.1 handles this (rive-ios#443)updateReferencedAssetsis called on experimental backend (not supported — concurrency API can't update already-bound artboard assets)TaskGroupto sequential to ensure command queue orderingExperimentalAssetLoadertypefields to OutOfBandAssets exampleexpo-fontplugin forkanit_regular.ttfin expo examplesTest plan
Fit.Layouton first mountupdateReferencedAssetslogs a warning instead of silently failing